Skip to content

chore(swift-sdk): reduce swift-sdk test time in CI #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 3 commits into from
Jul 23, 2026
Merged

chore(swift-sdk): reduce swift-sdk test time in CI #3869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
971c3f8
chore(swift-sdk): optimize swift-sdk build time
ZocoLini Jun 21, 2026
f126e6a
Merge branch 'v4.1-dev' into chore/optimize-sdk-ci
QuantumExplorer Jul 23, 2026
9ba4b21
chore(swift-sdk): document tests target in build_ios.sh help text
QuantumExplorer Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ opt-level = 3
[profile.dev-ios]
inherits = "dev"
panic = "abort"
lto = "thin"
debug = "line-tables-only"

# Android counterparts for the `rs-unified-sdk-jni` cdylib, used ONLY by
# `packages/kotlin-sdk/build_android.sh`. Unlike iOS, panic stays
Expand Down
1 change: 0 additions & 1 deletion packages/rs-platform-wallet-ffi/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ bs58 = "0.5"
zeroize = { version = "1", features = ["derive"] }

[dev-dependencies]
tempfile = "3.8"
dpp = { path = "../rs-dpp", features = ["fixtures-and-mocks"] }
platform-wallet = { path = "../rs-platform-wallet", features = ["test-utils"] }

Expand Down
1 change: 0 additions & 1 deletion packages/rs-platform-wallet-storage/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ windows-native-keyring-store = { version = "=1.0.0", optional = true }
[dev-dependencies]
proptest = "1"
assert_cmd = "2"
predicates = "3"
static_assertions = "1"
filetime = "0.2"
# Test-only: construct the `Zeroizing<[u8; 32]>` secret on an
Expand Down
4 changes: 3 additions & 1 deletion packages/swift-sdk/build_ios.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,14 @@ stage_target_artifacts() {
# Help
# -------------------------------
show_help() {
echo "Usage: $0 --target <ios|sim|mac> [--profile <dev|release>]"
echo "Usage: $0 --target <ios|sim|mac|all|tests> [--profile <dev|release>]"
echo ""
echo "Targets:"
echo " ios -> iPhone device"
echo " sim -> auto-detected iOS simulator"
echo " mac -> Apple Silicon Mac"
echo " all -> all targets"
echo " tests -> targets needed by run_tests.sh (sim + mac)"
echo ""
echo "Profile:"
echo " dev (default)"
Expand All @@ -109,6 +110,7 @@ while [[ $# -gt 0 ]]; do
sim) BUILD_SIM=true ;;
mac) BUILD_MAC=true ;;
all) BUILD_IOS=true; BUILD_SIM=true; BUILD_MAC=true ;;
tests) BUILD_SIM=true; BUILD_MAC=true ;;
Comment thread
ZocoLini marked this conversation as resolved.
*) log_error "Unknown target $2"; show_help ;;
esac
shift 2
Expand Down
8 changes: 1 addition & 7 deletions packages/swift-sdk/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
#!/bin/bash
set -euo pipefail

# This script builds the sdk using `build_ios.sh` for all targets,
# then runs the DashSDKFFI tests, and finally runs the
# ExampleApp tests on a selected iOS Simulator

SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
cd "$SCRIPT_DIR" || exit 1

Expand Down Expand Up @@ -50,10 +46,8 @@ if [ -z "$SIM_NAME" ]; then
exit 1
fi

bash build_ios.sh --target all --profile dev
bash build_ios.sh --target tests --profile dev
Comment thread
ZocoLini marked this conversation as resolved.

swift package clean
swift build
swift test
Comment thread
ZocoLini marked this conversation as resolved.

xcodebuild test \
Expand Down
Loading