Skip to content

fix(wasm-sdk): support binary grove path elements #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shumkov merged 4 commits into from
May 22, 2026
Merged

fix(wasm-sdk): support binary grove path elements #3657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0053bef
fix(wasm-sdk): support binary grove path elements
PastaPastaPasta May 17, 2026
3d11ae7
fix(wasm-sdk): allow non-ASCII UTF-8 in path/key legacy display
PastaPastaPasta May 19, 2026
ec22be7
refactor(wasm-sdk): address grove path element review nits
PastaPastaPasta May 20, 2026
04bd8f4
fix(wasm-sdk): handle ProvableCountProvableSumTree grove element
PastaPastaPasta May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/js-evo-sdk/src/system/facade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,18 @@ export class SystemFacade {
return w.getPrefundedSpecializedBalanceWithProofInfo(identityId);
}

async pathElements(path: string[], keys: string[]): Promise<wasm.PathElement[]> {
async pathElements(
path: wasm.GrovePathSegment[],
keys: wasm.GrovePathSegment[],
): Promise<wasm.PathElement[]> {
const w = await this.sdk.getWasmSdkConnected();
return w.getPathElements(path, keys);
}

async pathElementsWithProof(path: string[], keys: string[]):
Promise<wasm.ProofMetadataResponseTyped<wasm.PathElement[]>> {
async pathElementsWithProof(
path: wasm.GrovePathSegment[],
keys: wasm.GrovePathSegment[],
): Promise<wasm.ProofMetadataResponseTyped<wasm.PathElement[]>> {
const w = await this.sdk.getWasmSdkConnected();
return w.getPathElementsWithProofInfo(path, keys);
}
Expand Down
14 changes: 12 additions & 2 deletions packages/js-evo-sdk/tests/unit/facades/system.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,25 @@ describe('SystemFacade', () => {

describe('pathElements()', () => {
it('should forward to getPathElements', async () => {
await client.system.pathElements(['p'], ['k']);
const path = ['p', new Uint8Array([0x80, 0xff])];
const keys = [new Uint8Array([0x01, 0x02])];

await client.system.pathElements(path, keys);

expect(getPathElementsStub).to.be.calledOnce();
expect(getPathElementsStub).to.be.calledWithExactly(path, keys);
});
});

describe('pathElementsWithProof()', () => {
it('should forward to getPathElementsWithProofInfo', async () => {
await client.system.pathElementsWithProof(['p2'], ['k2']);
const path = ['p2', new Uint8Array([0x80, 0xff])];
const keys = [new Uint8Array([0x03, 0x04])];

await client.system.pathElementsWithProof(path, keys);

expect(getPathElementsWithProofInfoStub).to.be.calledOnce();
expect(getPathElementsWithProofInfoStub).to.be.calledWithExactly(path, keys);
});
});
});
Loading
Loading