Skip to content

Conversation

@lklimek
Copy link
Contributor

@lklimek lklimek commented Nov 28, 2025

Issue being fixed or feature implemented

Backport of #2824 from v2.1 to v2.2 which was incorrectly applied during merge

Summary by CodeRabbit

  • New Features
    • Enhanced platform DAPI profile selection with configurable options to include all available profiles or select them conditionally based on version status.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The getConfigProfiles function signature was updated to accept an optional includeAll parameter. When platform is enabled, the function conditionally appends DAPI profiles: either both deprecated and rs variants when includeAll is true, or selectively appends one based on the platform.dapi.deprecated.enabled flag when false.

Changes

Cohort / File(s) Change Summary
Config Profile Selection Enhancement
packages/dashmate/src/config/getConfigProfilesFactory.js
Updated getConfigProfiles function to accept optional includeAll parameter (defaults to false). Added conditional logic to append platform DAPI profiles: both platform-dapi-deprecated and platform-dapi-rs when includeAll is true; otherwise, selectively append based on platform.dapi.deprecated.enabled status.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Single file modification with straightforward parameter addition
  • Conditional branching logic is clear and linear
  • Optional parameter with sensible default reduces breaking change risk

Poem

🐰 A profile selector hops with glee,
With includeAll set, both paths are free!
Deprecated or fresh—pick one or two,
Config flexibility blooms anew! 🌱

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes a specific bug fix: rs-dapi not being stopped during dashmate reset with platform and force flags. It directly relates to the PR's objective of fixing this issue through backporting.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lklimek lklimek changed the title backport(dashmate): rs-dapi not stopped when dashmate reset --platform -f is called chore(dashmate): backport rs-dapi not stopped when dashmate reset --platform -f is called Nov 28, 2025
@lklimek lklimek changed the base branch from v2.2-dev to backport/2.1.3 November 28, 2025 10:33
@lklimek
Copy link
Contributor Author

lklimek commented Nov 28, 2025

@lklimek lklimek merged commit ae65e84 into backport/2.1.3 Nov 28, 2025
217 of 262 checks passed
@lklimek lklimek deleted the backport/pr-2842 branch November 28, 2025 11:45
@github-actions
Copy link

✅ DashSDKFFI.xcframework built for this PR.

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "c543c58a5e9641b1741525d5660c7615b300696902b1e65c9e5510782c042ac6"
)

Xcode manual integration:

  • Download 'DashSDKFFI.xcframework' artifact from the run link above.
  • Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
  • If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

@thephez thephez added this to the v2.1.x milestone Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants