Skip to content

Conversation

@QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@github-actions
Copy link

github-actions bot commented Nov 22, 2025

❌ gRPC Query Coverage Report

================================================================================
gRPC Query Coverage Report - NEW QUERIES ONLY
================================================================================

Total queries in proto: 49
Previously known queries: 47
New queries found: 2

================================================================================

New Query Implementation Status:
--------------------------------------------------------------------------------
✗ getAddressInfo                                NOT FOUND
✗ getAddressesInfos                             NOT FOUND

================================================================================
Summary:
--------------------------------------------------------------------------------
New queries implemented: 0 (0.0%)
New queries missing: 2 (100.0%)

Total known queries: 49
  - Implemented: 44
  - Not implemented: 4
  - Excluded: 1

Not implemented queries:
  - getAddressInfo
  - getAddressesInfos
  - getConsensusParams
  - getTokenPreProgrammedDistributions

Missing NEW queries:
  - getAddressInfo
  - getAddressesInfos

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 22, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/singleUseKeys

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@QuantumExplorer QuantumExplorer marked this pull request as draft November 22, 2025 21:03
fn sign(&self, key: &K, data: &[u8]) -> Result<BinaryData, ProtocolError>;

/// the public key bytes are only used to look up the private key
fn sign_create_witness(&self, key: &K, data: &[u8]) -> Result<AddressWitness, ProtocolError>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should move sign_create_witness() out of signer, into new trait

#[cfg(feature = "state-transition-signing")]
fn try_from_asset_lock_with_signer<S: Signer<PlatformAddress>>(
asset_lock_proof: AssetLockProof,
asset_lock_proof_private_key: &[u8],
Copy link
Contributor

@lklimek lklimek Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using Signer trait instead of providing private key everywhere. DPP should never receive private key bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants