-
Notifications
You must be signed in to change notification settings - Fork 45
feat: addresses on the Platform chain #2866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2.2-dev
Are you sure you want to change the base?
Conversation
❌ gRPC Query Coverage Report |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| fn sign(&self, key: &K, data: &[u8]) -> Result<BinaryData, ProtocolError>; | ||
|
|
||
| /// the public key bytes are only used to look up the private key | ||
| fn sign_create_witness(&self, key: &K, data: &[u8]) -> Result<AddressWitness, ProtocolError>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should move sign_create_witness() out of signer, into new trait
| #[cfg(feature = "state-transition-signing")] | ||
| fn try_from_asset_lock_with_signer<S: Signer<PlatformAddress>>( | ||
| asset_lock_proof: AssetLockProof, | ||
| asset_lock_proof_private_key: &[u8], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using Signer trait instead of providing private key everywhere. DPP should never receive private key bytes.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only