Skip to content

Conversation

@QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Oct 24, 2025

Issue being fixed or feature implemented

Release new Dash Platform version

What was done?

  • Updated changelog
  • Bumped packages version

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where dapi was not properly removed after migration
    • Enhanced Swift 6 compatibility for SPV C callbacks, eliminating race conditions and timing-of-check-to-time-of-use (TOCTOU) vulnerabilities

@QuantumExplorer QuantumExplorer added this to the v2.1.0 milestone Oct 24, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Version bump from 2.1.0-rc.1 to 2.1.0-rc.2 across all project manifests. CHANGELOG.md updated with release notes documenting two bug fixes for dashmate and swift-sdk.

Changes

Cohort / File(s) Summary
Release documentation
CHANGELOG.md
Added release section for 2.1.0-rc.2 (2025-10-24) with bug fix entries for dashmate (dapi removal post migration) and swift-sdk (SPV C callbacks Swift 6 safety)
Node.js package manifests
package.json, packages/bench-suite/package.json, packages/dapi-grpc/package.json, packages/dapi/package.json, packages/dash-spv/package.json, packages/dashmate/package.json, packages/dashpay-contract/package.json, packages/dpns-contract/package.json, packages/feature-flags-contract/package.json, packages/js-dapi-client/package.json, packages/js-dash-sdk/package.json, packages/js-evo-sdk/package.json, packages/js-grpc-common/package.json, packages/keyword-search-contract/package.json, packages/masternode-reward-shares-contract/package.json, packages/platform-test-suite/package.json, packages/token-history-contract/package.json, packages/wallet-lib/package.json, packages/wallet-utils-contract/package.json, packages/wasm-dpp/package.json, packages/wasm-drive-verify/package.json, packages/wasm-sdk/package.json, packages/withdrawals-contract/package.json
Version field updated from "2.1.0-rc.1" to "2.1.0-rc.2"
Rust package manifests (Cargo.toml)
packages/check-features/Cargo.toml, packages/dapi-grpc/Cargo.toml, packages/dash-platform-balance-checker/Cargo.toml, packages/dashpay-contract/Cargo.toml, packages/data-contracts/Cargo.toml, packages/dpns-contract/Cargo.toml, packages/feature-flags-contract/Cargo.toml, packages/keyword-search-contract/Cargo.toml, packages/masternode-reward-shares-contract/Cargo.toml, packages/rs-context-provider/Cargo.toml, packages/rs-dapi-client/Cargo.toml, packages/rs-dapi-grpc-macros/Cargo.toml, packages/rs-dapi/Cargo.toml, packages/rs-dash-event-bus/Cargo.toml, packages/rs-dpp/Cargo.toml, packages/rs-drive-abci/Cargo.toml, packages/rs-drive-proof-verifier/Cargo.toml, packages/rs-drive/Cargo.toml, packages/rs-json-schema-compatibility-validator/Cargo.toml, packages/rs-platform-serialization-derive/Cargo.toml, packages/rs-platform-serialization/Cargo.toml, packages/rs-platform-value-convertible/Cargo.toml, packages/rs-platform-value/Cargo.toml, packages/rs-platform-version/Cargo.toml, packages/rs-platform-versioning/Cargo.toml, packages/rs-platform-wallet/Cargo.toml, packages/rs-sdk-ffi/Cargo.toml, packages/rs-sdk-trusted-context-provider/Cargo.toml, packages/rs-sdk/Cargo.toml, packages/simple-signer/Cargo.toml, packages/strategy-tests/Cargo.toml, packages/token-history-contract/Cargo.toml, packages/wallet-utils-contract/Cargo.toml, packages/wasm-dpp/Cargo.toml, packages/wasm-drive-verify/Cargo.toml, packages/wasm-sdk/Cargo.toml, packages/withdrawals-contract/Cargo.toml
Version field in [package] section updated from "2.1.0-rc.1" to "2.1.0-rc.2"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

The changes are highly homogeneous—the same version bump applied uniformly across 50+ manifest files plus one CHANGELOG update. Review consists of verifying changelog content accuracy and spot-checking version consistency across representative files.

Possibly related PRs

Suggested reviewers

  • shumkov
  • lklimek

Poem

🐰 A version bump hops into the night,
From rc.1 to rc.2, shining bright,
Fifty manifests in perfect sync,
Swift and dashmate bugs now on the brink—
Release day brings our project to its peak! ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release_2.1.0-rc.2

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34b9cce and 094f143.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (61)
  • CHANGELOG.md (1 hunks)
  • package.json (1 hunks)
  • packages/bench-suite/package.json (1 hunks)
  • packages/check-features/Cargo.toml (1 hunks)
  • packages/dapi-grpc/Cargo.toml (1 hunks)
  • packages/dapi-grpc/package.json (1 hunks)
  • packages/dapi/package.json (1 hunks)
  • packages/dash-platform-balance-checker/Cargo.toml (1 hunks)
  • packages/dash-spv/package.json (1 hunks)
  • packages/dashmate/package.json (1 hunks)
  • packages/dashpay-contract/Cargo.toml (1 hunks)
  • packages/dashpay-contract/package.json (1 hunks)
  • packages/data-contracts/Cargo.toml (1 hunks)
  • packages/dpns-contract/Cargo.toml (1 hunks)
  • packages/dpns-contract/package.json (1 hunks)
  • packages/feature-flags-contract/Cargo.toml (1 hunks)
  • packages/feature-flags-contract/package.json (1 hunks)
  • packages/js-dapi-client/package.json (1 hunks)
  • packages/js-dash-sdk/package.json (1 hunks)
  • packages/js-evo-sdk/package.json (1 hunks)
  • packages/js-grpc-common/package.json (1 hunks)
  • packages/keyword-search-contract/Cargo.toml (1 hunks)
  • packages/keyword-search-contract/package.json (1 hunks)
  • packages/masternode-reward-shares-contract/Cargo.toml (1 hunks)
  • packages/masternode-reward-shares-contract/package.json (1 hunks)
  • packages/platform-test-suite/package.json (1 hunks)
  • packages/rs-context-provider/Cargo.toml (1 hunks)
  • packages/rs-dapi-client/Cargo.toml (1 hunks)
  • packages/rs-dapi-grpc-macros/Cargo.toml (1 hunks)
  • packages/rs-dapi/Cargo.toml (1 hunks)
  • packages/rs-dash-event-bus/Cargo.toml (1 hunks)
  • packages/rs-dpp/Cargo.toml (1 hunks)
  • packages/rs-drive-abci/Cargo.toml (1 hunks)
  • packages/rs-drive-proof-verifier/Cargo.toml (1 hunks)
  • packages/rs-drive/Cargo.toml (1 hunks)
  • packages/rs-json-schema-compatibility-validator/Cargo.toml (1 hunks)
  • packages/rs-platform-serialization-derive/Cargo.toml (1 hunks)
  • packages/rs-platform-serialization/Cargo.toml (1 hunks)
  • packages/rs-platform-value-convertible/Cargo.toml (1 hunks)
  • packages/rs-platform-value/Cargo.toml (1 hunks)
  • packages/rs-platform-version/Cargo.toml (1 hunks)
  • packages/rs-platform-versioning/Cargo.toml (1 hunks)
  • packages/rs-platform-wallet/Cargo.toml (1 hunks)
  • packages/rs-sdk-ffi/Cargo.toml (1 hunks)
  • packages/rs-sdk-trusted-context-provider/Cargo.toml (1 hunks)
  • packages/rs-sdk/Cargo.toml (1 hunks)
  • packages/simple-signer/Cargo.toml (1 hunks)
  • packages/strategy-tests/Cargo.toml (1 hunks)
  • packages/token-history-contract/Cargo.toml (1 hunks)
  • packages/token-history-contract/package.json (1 hunks)
  • packages/wallet-lib/package.json (1 hunks)
  • packages/wallet-utils-contract/Cargo.toml (1 hunks)
  • packages/wallet-utils-contract/package.json (1 hunks)
  • packages/wasm-dpp/Cargo.toml (1 hunks)
  • packages/wasm-dpp/package.json (1 hunks)
  • packages/wasm-drive-verify/Cargo.toml (1 hunks)
  • packages/wasm-drive-verify/package.json (1 hunks)
  • packages/wasm-sdk/Cargo.toml (1 hunks)
  • packages/wasm-sdk/package.json (1 hunks)
  • packages/withdrawals-contract/Cargo.toml (1 hunks)
  • packages/withdrawals-contract/package.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

✅ gRPC Query Coverage Report

================================================================================
gRPC Query Coverage Report - NEW QUERIES ONLY
================================================================================

Total queries in proto: 47
Previously known queries: 47
New queries found: 0


================================================================================
Summary:
--------------------------------------------------------------------------------
No new queries found

Total known queries: 47
  - Implemented: 44
  - Not implemented: 2
  - Excluded: 1

Not implemented queries:
  - getConsensusParams
  - getTokenPreProgrammedDistributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants