Skip to content

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Oct 2, 2025

Issue being fixed or feature implemented

We want users to subscribe to events, like document deleted.

What was done?

Added some infrastructure to subscribe to events and notify subscribers about events to all layers except DAPI.

DAPI part will be done in separate PR #2716

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/drive-event-bus

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

github-actions bot commented Oct 2, 2025

❌ gRPC Query Coverage Report

================================================================================
gRPC Query Coverage Report - NEW QUERIES ONLY
================================================================================

Total queries in proto: 48
Previously known queries: 47
New queries found: 1

================================================================================

New Query Implementation Status:
--------------------------------------------------------------------------------
✗ subscribePlatformEvents                       NOT FOUND

================================================================================
Summary:
--------------------------------------------------------------------------------
New queries implemented: 0 (0.0%)
New queries missing: 1 (100.0%)

Total known queries: 48
  - Implemented: 44
  - Not implemented: 3
  - Excluded: 1

Not implemented queries:
  - getConsensusParams
  - getTokenPreProgrammedDistributions
  - subscribePlatformEvents

Missing NEW queries:
  - subscribePlatformEvents

@lklimek
Copy link
Contributor Author

lklimek commented Oct 2, 2025

@coderabbitai review all

Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

@lklimek: I'll perform a comprehensive review of all the changes in this PR.

✅ Actions performed

Full review triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant