Skip to content

build: update rust to 1.89 #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
+4 −5
Merged

build: update rust to 1.89 #2755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,11 @@ members = [
"packages/token-history-contract",
"packages/keyword-search-contract",
"packages/wasm-drive-verify",
"packages/dash-platform-balance-checker"
"packages/dash-platform-balance-checker",
]

exclude = ["packages/wasm-sdk"] # This one is experimental and not ready for use

[workspace.package]

rust-version = "1.85"

rust-version = "1.89"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

MSRV raised to 1.89 — verify CI and per-crate overrides

Ensure CI/tooling (e.g., Docker images, actions, Makefiles) don’t pin older Rust, and that no crate overrides rust-version inconsistently.

Run to spot lingering pins:

🏁 Script executed:

#!/bin/bash
# Find old pins/usages
rg -nP '\b1\.85\b|\bstable-1\.85\b|rustc 1\.85' -g '!**/target/**' -S

# List any per-crate rust-version overrides
rg -nP '^\s*rust-version\s*=\s*".+?"' -g '!**/target/**' -S

# Check CI/tooling references
fd -H tests.yml .github | xargs rg -nP '\b(1\.85|1\.89)\b' -S
fd -H Dockerfile | xargs rg -nP '\b(1\.85|1\.89)\b' -S

Length of output: 456

Per-crate MSRV override needs update
packages/wasm-drive-verify/Cargo.toml (line 6) still pins rust-version = "1.74" — bump to "1.89" or remove the override to match the workspace MSRV. No CI or Dockerfile references to 1.85 remain.

🤖 Prompt for AI Agents 
In packages/wasm-drive-verify/Cargo.toml around line 6, the per-crate MSRV is
pinned to rust-version = "1.74" which conflicts with the workspace MSRV of 1.89;
update that rust-version entry to "1.89" (or remove the rust-version override
entirely) so the crate matches the workspace MSRV, and scan other crate
Cargo.toml files to ensure no remaining per-crate overrides still reference
older Rust versions.

2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ this repository may be used on the following networks:
- Install prerequisites:
- [node.js](https://nodejs.org/) v20
- [docker](https://docs.docker.com/get-docker/) v20.10+
- [rust](https://www.rust-lang.org/tools/install) v1.85+, with wasm32 target (`rustup target add wasm32-unknown-unknown`)
- [rust](https://www.rust-lang.org/tools/install) v1.89+, with wasm32 target (`rustup target add wasm32-unknown-unknown`)
- [protoc - protobuf compiler](https://github.com/protocolbuffers/protobuf/releases) v27.3+
- if needed, set PROTOC environment variable to location of `protoc` binary
- [wasm-bingen toolchain](https://rustwasm.github.io/wasm-bindgen/):
Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[toolchain]
# Rust version the same as in /README.md
channel = "1.85"
channel = "1.89"

targets = ["wasm32-unknown-unknown"]
Loading