Skip to content

fix(wasm-sdk): fix nft transitions #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

fix(wasm-sdk): fix nft transitions #2751

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c38f5e8
fix(wasm-sdk): improve document purchase and price update transitions
thephez Aug 28, 2025
4c72075
fix(wasm-sdk): increment document revision for transfer transitions
thephez Aug 28, 2025
a2e615f
fix(wasm-sdk): improve document revision handling with error checking
thephez Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 67 additions & 37 deletions packages/wasm-sdk/src/state_transitions/documents/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,15 @@ impl WasmSdk {

Ok(result_obj.into())
}

/// Get the next revision for a document, handling errors for missing revisions and overflow
fn get_next_revision(document: &dash_sdk::platform::Document) -> Result<u64, JsValue> {
let current_revision = document.revision()
.ok_or_else(|| JsValue::from_str("Document revision is missing"))?;

current_revision.checked_add(1)
.ok_or_else(|| JsValue::from_str("Document revision overflow"))
}
}

#[wasm_bindgen]
Expand Down Expand Up @@ -835,7 +844,8 @@ impl WasmSdk {
.map_err(|e| JsValue::from_str(&format!("Failed to fetch document: {}", e)))?
.ok_or_else(|| JsValue::from_str("Document not found"))?;

let current_revision = existing_doc.revision().unwrap_or(0);
let current_revision = existing_doc.revision()
.ok_or_else(|| JsValue::from_str("Document revision is missing"))?;

// Fetch the identity to get the correct key
let identity = dash_sdk::platform::Identity::fetch(&sdk, owner_identifier)
Expand Down Expand Up @@ -965,6 +975,26 @@ impl WasmSdk {
.map_err(|e| JsValue::from_str(&format!("Failed to fetch document: {}", e)))?
.ok_or_else(|| JsValue::from_str("Document not found"))?;

// Get the current revision and increment it
let next_revision = Self::get_next_revision(&document)?;

// Create a modified document with incremented revision for the transfer transition
let transfer_document = Document::V0(DocumentV0 {
id: document.id(),
owner_id: document.owner_id(),
properties: document.properties().clone(),
revision: Some(next_revision),
created_at: document.created_at(),
updated_at: document.updated_at(),
transferred_at: document.transferred_at(),
created_at_block_height: document.created_at_block_height(),
updated_at_block_height: document.updated_at_block_height(),
transferred_at_block_height: document.transferred_at_block_height(),
created_at_core_block_height: document.created_at_core_block_height(),
updated_at_core_block_height: document.updated_at_core_block_height(),
transferred_at_core_block_height: document.transferred_at_core_block_height(),
});

// Fetch the identity to get the correct key
let identity = dash_sdk::platform::Identity::fetch(&sdk, owner_identifier)
.await
Expand All @@ -983,7 +1013,7 @@ impl WasmSdk {

// Create a transfer transition
let transition = BatchTransition::new_document_transfer_transition_from_document(
document,
transfer_document,
document_type_ref,
recipient_identifier,
matching_key,
Expand Down Expand Up @@ -1089,6 +1119,26 @@ impl WasmSdk {
)));
}

// Get the current revision and increment it
let next_revision = Self::get_next_revision(&document)?;

// Create a modified document with incremented revision for the purchase transition
let purchase_document = Document::V0(DocumentV0 {
id: document.id(),
owner_id: document.owner_id(),
properties: document.properties().clone(),
revision: Some(next_revision),
created_at: document.created_at(),
updated_at: document.updated_at(),
transferred_at: document.transferred_at(),
created_at_block_height: document.created_at_block_height(),
updated_at_block_height: document.updated_at_block_height(),
transferred_at_block_height: document.transferred_at_block_height(),
created_at_core_block_height: document.created_at_core_block_height(),
updated_at_core_block_height: document.updated_at_core_block_height(),
transferred_at_core_block_height: document.transferred_at_core_block_height(),
});

// Fetch buyer identity
let buyer_identity = dash_sdk::platform::Identity::fetch(&sdk, buyer_identifier)
.await
Expand All @@ -1107,7 +1157,7 @@ impl WasmSdk {

// Create document purchase transition
let transition = BatchTransition::new_document_purchase_transition_from_document(
document.into(),
purchase_document,
document_type_ref,
buyer_identifier,
price as Credits,
Expand Down Expand Up @@ -1226,25 +1276,15 @@ impl WasmSdk {
return Err(JsValue::from_str("Only the document owner can set its price"));
}

// Get existing document properties and convert to mutable map
let mut properties = existing_doc.properties().clone();

// Update the price in the document properties
let price_value = if price > 0 {
PlatformValue::U64(price)
} else {
PlatformValue::Null
};
// Get the current revision and increment it
let next_revision = Self::get_next_revision(&existing_doc)?;

properties.insert("$price".to_string(), price_value);

// Create updated document with new properties
let new_revision = existing_doc.revision().unwrap_or(0) + 1;
let updated_doc = Document::V0(DocumentV0 {
id: doc_id,
owner_id: owner_identifier,
properties,
revision: Some(new_revision),
// Create a modified document with incremented revision for the price update transition
let price_update_document = Document::V0(DocumentV0 {
id: existing_doc.id(),
owner_id: existing_doc.owner_id(),
properties: existing_doc.properties().clone(),
revision: Some(next_revision),
created_at: existing_doc.created_at(),
updated_at: existing_doc.updated_at(),
transferred_at: existing_doc.transferred_at(),
Expand Down Expand Up @@ -1272,30 +1312,20 @@ impl WasmSdk {
.await
.map_err(|e| JsValue::from_str(&format!("Failed to fetch nonce: {}", e)))?;

// Generate entropy for the state transition
let entropy_bytes = {
let mut entropy = [0u8; 32];
if let Some(window) = web_sys::window() {
if let Ok(crypto) = window.crypto() {
let _ = crypto.get_random_values_with_u8_array(&mut entropy);
}
}
entropy
};

// Create the price update transition
let transition = BatchTransition::new_document_replacement_transition_from_document(
updated_doc,
// Create the price update transition using the dedicated method
let transition = BatchTransition::new_document_update_price_transition_from_document(
price_update_document,
document_type_ref,
matching_key,
price,
&matching_key,
identity_contract_nonce,
UserFeeIncrease::default(),
None, // token_payment_info
&signer,
sdk.version(),
None, // options
)
.map_err(|e| JsValue::from_str(&format!("Failed to create transition: {}", e)))?;
.map_err(|e| JsValue::from_str(&format!("Failed to create price update transition: {}", e)))?;

// The transition is already signed, convert to StateTransition
let state_transition: StateTransition = transition.into();
Expand Down
Loading