Skip to content

fix(drive): fix verification data contract verification logic with keeps history #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v2.1-dev
Choose a base branch
from
Open

fix(drive): fix verification data contract verification logic with keeps history #2727

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f45f15c
fix(drive): fix verification logic of contract known keeps history
pshenmic Aug 17, 2025
cf195a0
Merge branch 'v2.1-dev' into fix/drive-verify-contract
QuantumExplorer Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/rs-drive/src/verify/contract/verify_contract/v0/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,23 @@
})
.transpose();
match contract {
Ok(contract) => Ok((root_hash, contract)),
Ok(contract) => match contract {
None => {
if contract_known_keeps_history.unwrap_or_default() != true {

Check failure on line 132 in packages/rs-drive/src/verify/contract/verify_contract/v0/mod.rs

View workflow job for this annotation

GitHub Actions / Rust packages (drive) / Linting

inequality checks against true can be replaced by a negation 

error: inequality checks against true can be replaced by a negation
   --> packages/rs-drive/src/verify/contract/verify_contract/v0/mod.rs:132:28
    |
132 |                         if contract_known_keeps_history.unwrap_or_default() != true {
    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!contract_known_keeps_history.unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
    = note: `-D clippy::bool-comparison` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::bool_comparison)]`
Self::verify_contract(
proof,
Some(true),
is_proof_subset,
in_multiple_contract_proof_form,
contract_id,
platform_version,
)
} else{
Ok((root_hash, contract))
}
}
Some(_) => Ok((root_hash, contract))
},
Err(e) => {
if contract_known_keeps_history.is_some() {
// just return error
Expand Down
Loading