fix(platform): npm audit security for tar-fs #2656

pshenmic · 2025-06-03T08:25:10Z

Issue being fixed or feature implemented

All PRs to v2.0-dev currently failing with such message on the CI:

└─ tar-fs
   ├─ ID: 1105197
   ├─ Issue: tar-fs can extract outside the specified dir with a specific tarball
   ├─ URL: https://github.com/advisories/GHSA-8cj5-5rvv-wf4v
   ├─ Severity: high
   ├─ Vulnerable Versions: >=2.0.0 <2.1.3
   │ 
   ├─ Tree Versions
   │  └─ 2.1.2
   │ 
   └─ Dependents
      └─ dockerode@npm:4.0.6

And tar-fs v2 versions considered unsafe leading to CI fail on NPM security check.

This module is used by dockerode npm package that is being used by dashmate.

What was done?

Set fixed resolution of tar-fs to latest version 3.0.9

How Has This Been Tested?

Only by typing yarn

Breaking Changes

No

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

I have assigned this pull request to a milestone

Summary by CodeRabbit

Chores
- Updated internal package dependencies with the latest versions of tar file handling and stream-related packages.
- Added a resolution for "tar-fs" version 3.0.9 to ensure consistent dependency management.

No visible changes to features or user interface.

coderabbitai · 2025-06-03T08:25:18Z

Walkthrough

The changes update the project's dependency management by upgrading and adding several packages related to tar file handling and stream processing. The .pnp.cjs file reflects these updates, including new package entries, the removal of obsolete dependencies, and the upgrade of tar-fs and tar-stream. The package.json file is updated to enforce the new tar-fs version via the resolutions field.

Changes

File(s)	Change Summary
`.pnp.cjs`	Updated package dependency graph: added new packages (`b4a`, `bare-*`, `fast-fifo`, `streamx`, etc.), upgraded `tar-fs` and `tar-stream`, and removed obsolete packages (`chownr`, `mkdirp-classic`, `fs-constants`). Adjusted link types and dependencies accordingly.
`package.json`	Replaced `"base-x": "^3.0.11"` with `"tar-fs": "^3.0.9"` in the `resolutions` section to enforce the new version.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant [email protected]
    participant [email protected]
    participant bare-fs
    participant bare-path
    participant b4a
    participant fast-fifo
    participant streamx

    App->>[email protected]: Use tar-fs API
    [email protected]>>bare-fs: File operations
    [email protected]>>bare-path: Path handling
    [email protected]>>[email protected]: Stream tar data
    [email protected]>>b4a: Buffer operations
    [email protected]>>fast-fifo: FIFO queue
    [email protected]>>streamx: Stream management

Suggested reviewers

shumkov

Poem

In the warren of code, dependencies grow,
New packages hop in, old ones must go.
Tar-fs now stronger, with friends by its side,
Streams run smoother, on this upgrade ride.
🐇 With each fresh install, the project will gleam—
A rabbit’s delight, in the open-source stream!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7cdc480 and 8a9bef1.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (1)

package.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

package.json

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
GitHub Check: Build JS packages / Build JS

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5008b6d and 7cdc480.

⛔ Files ignored due to path filters (18)

.yarn/cache/b4a-npm-1.6.7-a52d28b4e2-1ac056e3bc.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/bare-events-npm-2.5.4-ff815c1e18-135ef380b1.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/bare-fs-npm-4.1.5-f5308cecd1-81334c45db.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/bare-os-npm-3.6.1-4544809acf-285d95c391.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/bare-path-npm-3.0.0-d42919fc21-712d90e9cd.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/bare-stream-npm-2.6.5-1977dd457e-0f5ca2167f.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/chownr-npm-1.1.4-5bd400ab08-115648f8eb.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/fast-fifo-npm-1.3.2-391cc25df4-6bfcba3e4d.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/fs-constants-npm-1.0.0-59576b2177-18f5b71837.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/mkdirp-classic-npm-0.5.3-3b5c991910-3f4e088208.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/streamx-npm-2.22.0-6953aefe6d-9c329bb316.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/tar-fs-npm-2.0.1-0734c93785-85ceac6fce.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/tar-fs-npm-2.1.2-4231292dd1-623f7e8e58.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/tar-fs-npm-3.0.9-3078dff77a-00e194ef36.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/tar-stream-npm-2.2.0-884c79b510-1a52a51d24.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/tar-stream-npm-3.1.7-c34f9aa00f-b21a82705a.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/text-decoder-npm-1.2.3-cc7432569a-bcdec33c0f.zip is excluded by !**/.yarn/**, !**/*.zip
yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (2)

.pnp.cjs (8 hunks)
package.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
GitHub Check: Build JS packages / Build JS

🔇 Additional comments (9)

package.json (1)

103-103: Enforce secure tar-fs version (GHSA-8cj5-5rvv-wf4v)
Pinning "tar-fs" to ^3.0.9 addresses the high-severity path‐traversal vulnerability in versions <2.1.3 and resolves the CI audit failures.

.pnp.cjs (8)

6405-6413: Auto-generated Yarn PnP entry for [email protected]
This change reflects the updated dependency graph after bumping tar-fs to a safe version. No manual action required.

6551-6630: Auto-generated Yarn PnP entries for bare-events, bare-fs, bare-os, bare-path, and bare-stream
These packages were introduced as new runtime dependencies of the upgraded tar-fs and tar-stream versions. All entries look consistent with the resolution in package.json. No manual action required.

9194-9194: Auto-generated Yarn PnP update for tar-fs in dockerode’s dependency list
The tar-fs version is upgraded to 3.0.9 under dockerode. This matches the security resolution. No manual action required.

9207-9207: Auto-generated Yarn PnP update for tar-fs in @grpc/proto-loader dependency list
The tar-fs version is upgraded to 3.0.9 under the gRPC loader dependencies. No manual action required.

10371-10379: Auto-generated Yarn PnP entry for [email protected]
This addition supports the upgraded tar-stream package. No manual action required.

17914-17925: Auto-generated Yarn PnP entry for [email protected]
Introduced as a new dependency of tar-stream. All metadata aligns with the resolution update. No manual action required.

18265-18273: Auto-generated Yarn PnP entries for [email protected] and [email protected]
These entries capture the safe versions of both packages and their dependencies. No manual action required.

18541-18550: Auto-generated Yarn PnP entry for [email protected]
Added as a dependency of streamx in the updated resolution set. No manual action required.

package.json

pshenmic added 2 commits June 3, 2025 15:20

fix(platform): set resolution of tar-fs to 3.0.9 (security fix)

f3b7c9a

fix(platform): add missing yarn cache

7cdc480

pshenmic added this to the v2.0.0 milestone Jun 3, 2025

pshenmic requested a review from QuantumExplorer as a code owner June 3, 2025 08:25

coderabbitai bot reviewed Jun 3, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

fix(platform): remove unnecessary resolution for x-base

8a9bef1

QuantumExplorer approved these changes Jun 3, 2025

View reviewed changes

QuantumExplorer merged commit 4a56fed into v2.0-dev Jun 3, 2025
19 checks passed

QuantumExplorer deleted the feat/js-audit-fix branch June 3, 2025 09:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(platform): npm audit security for tar-fs #2656

fix(platform): npm audit security for tar-fs #2656

Uh oh!

pshenmic commented Jun 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 3, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(platform): npm audit security for tar-fs #2656

fix(platform): npm audit security for tar-fs #2656

Uh oh!

Conversation

pshenmic commented Jun 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pshenmic commented Jun 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)