-
Notifications
You must be signed in to change notification settings - Fork 44
chore: bump to 2.0.0-rc.6 #2596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change updates the version numbers from Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/dashmate/package.json (1)
1-4: Ensure lockfile and changelog are updated.
After bumping the package version, please verify that your lockfile (yarn.lockorpackage-lock.json) and any CHANGELOG or release notes reflect this new version.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (46)
package.json(1 hunks)packages/bench-suite/package.json(1 hunks)packages/check-features/Cargo.toml(1 hunks)packages/dapi-grpc/Cargo.toml(1 hunks)packages/dapi-grpc/package.json(1 hunks)packages/dapi/package.json(1 hunks)packages/dashmate/package.json(1 hunks)packages/dashpay-contract/Cargo.toml(1 hunks)packages/dashpay-contract/package.json(1 hunks)packages/data-contracts/Cargo.toml(1 hunks)packages/dpns-contract/Cargo.toml(1 hunks)packages/dpns-contract/package.json(1 hunks)packages/feature-flags-contract/Cargo.toml(1 hunks)packages/feature-flags-contract/package.json(1 hunks)packages/js-dapi-client/package.json(1 hunks)packages/js-dash-sdk/package.json(1 hunks)packages/js-grpc-common/package.json(1 hunks)packages/keyword-search-contract/Cargo.toml(1 hunks)packages/masternode-reward-shares-contract/Cargo.toml(1 hunks)packages/masternode-reward-shares-contract/package.json(1 hunks)packages/platform-test-suite/package.json(1 hunks)packages/rs-dapi-client/Cargo.toml(1 hunks)packages/rs-dapi-grpc-macros/Cargo.toml(1 hunks)packages/rs-dpp/Cargo.toml(1 hunks)packages/rs-drive-abci/Cargo.toml(1 hunks)packages/rs-drive-proof-verifier/Cargo.toml(1 hunks)packages/rs-drive/Cargo.toml(1 hunks)packages/rs-json-schema-compatibility-validator/Cargo.toml(1 hunks)packages/rs-platform-serialization-derive/Cargo.toml(1 hunks)packages/rs-platform-serialization/Cargo.toml(1 hunks)packages/rs-platform-value-convertible/Cargo.toml(1 hunks)packages/rs-platform-value/Cargo.toml(1 hunks)packages/rs-platform-version/Cargo.toml(1 hunks)packages/rs-platform-versioning/Cargo.toml(1 hunks)packages/rs-sdk/Cargo.toml(1 hunks)packages/simple-signer/Cargo.toml(1 hunks)packages/strategy-tests/Cargo.toml(1 hunks)packages/token-history-contract/Cargo.toml(1 hunks)packages/token-history-contract/package.json(1 hunks)packages/wallet-lib/package.json(1 hunks)packages/wallet-utils-contract/Cargo.toml(1 hunks)packages/wallet-utils-contract/package.json(1 hunks)packages/wasm-dpp/Cargo.toml(1 hunks)packages/wasm-dpp/package.json(1 hunks)packages/withdrawals-contract/Cargo.toml(1 hunks)packages/withdrawals-contract/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: QuantumExplorer
PR: dashpay/platform#2257
File: packages/rs-drive-abci/src/mimic/test_quorum.rs:159-164
Timestamp: 2024-11-20T16:16:01.830Z
Learning: QuantumExplorer prefers not to receive auto-generated messages asking to post on social media.
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Rust packages (wallet-utils-contract) / Unused dependencies
- GitHub Check: Rust packages (wallet-utils-contract) / Linting
- GitHub Check: Rust packages (wallet-utils-contract) / Tests
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust crates security audit
🔇 Additional comments (49)
packages/rs-dapi-client/Cargo.toml (1)
3-3: Confirm version bump to 2.0.0-rc.6
The version field has been correctly updated from2.0.0-rc.5to2.0.0-rc.6.
Please ensure that the workspace rootCargo.toml, CHANGELOG, CI pipelines, and any documentation reflect this new release candidate.packages/rs-sdk/Cargo.toml (1)
3-3: Version bump to 2.0.0-rc.6 looks good.This aligns with the coordinated RC-6 release across all Rust and JS packages. No further changes appear necessary here.
packages/keyword-search-contract/Cargo.toml (1)
4-4: Version bump to 2.0.0-rc.6 approvedThe crate version has been updated correctly from
2.0.0-rc.5to2.0.0-rc.6. No other metadata changes are needed here.packages/rs-drive-proof-verifier/Cargo.toml (1)
3-3: Version field updated to 2.0.0-rc.6
Theversionhas been correctly bumped from2.0.0-rc.5to2.0.0-rc.6, in line with the coordinated release candidate update across all crates.packages/rs-platform-versioning/Cargo.toml (1)
5-5:✅ Verification successful
Approve version update to 2.0.0-rc.6
Version metadata bump looks correct and aligns with the PR objectives. Ensure there are no lingering references to the previous2.0.0-rc.5across the workspace.Run the following script to verify:
🏁 Script executed:
#!/bin/bash # Verify that no Cargo.toml contains the old rc.5 version rg -n '"2\.0\.0-rc\.5"' -g '*.toml'Length of output: 37
Approve version bump to 2.0.0-rc.6
Verification complete: no occurrences of2.0.0-rc.5were found in anyCargo.toml.
All set!packages/rs-json-schema-compatibility-validator/Cargo.toml (2)
3-3: Approve the version bump.
The crate’s version has been correctly updated from2.0.0-rc.5to2.0.0-rc.6, in line with the release candidate increment.
1-21:✅ Verification successful
Verify no leftover
rc.5references.
Ensure all manifests, documentation, and scripts have been updated. Run this check to catch any lingeringrc.5identifiers:
🏁 Script executed:
#!/bin/bash # Search repository for any remaining `2.0.0-rc.5` references rg -n "2\\.0\\.0-rc\\.5"Length of output: 23
No remaining
2.0.0-rc.5references found
Ranrg -n '2\.0\.0-rc\.5'across the repository; no matches. All manifests, documentation, and scripts have been updated accordingly.packages/rs-drive-abci/Cargo.toml (2)
3-3: Bump to 2.0.0-rc.6 as intended.The version has been correctly updated from
2.0.0-rc.5to2.0.0-rc.6, aligning this package with the coordinated release candidate series.
1-127:✅ Verification successful
Verify no residual references to
rc.5.To ensure consistency across the repository, please check that no other manifest files still reference the previous
2.0.0-rc.5version.
🏁 Script executed:
#!/bin/bash # Verify that no Cargo.toml files reference the old rc.5 version rg -n '"2.0.0-rc.5"' --glob '*/Cargo.toml'Length of output: 193
🏁 Script executed:
#!/bin/bash # Verify that no Cargo.toml files reference the old rc.5 version across the entire repository echo "Searching with ripgrep..." rg -n '2\.0\.0-rc\.5' -g '**/Cargo.toml' || echo "No references found via ripgrep." echo "Fallback search with find + grep..." find . -type f -name Cargo.toml -print0 | xargs -0 grep -Hn '2\.0\.0-rc\.5' || echo "No references found via grep."Length of output: 406
No residual references to
2.0.0-rc.5found
All Cargo.toml manifest files have been updated to2.0.0-rc.6. No further changes are required.packages/wasm-dpp/package.json (1)
3-3: Consistent version bump to 2.0.0-rc.6
Updated the package version to the new release candidate as part of the coordinated 2.0.0-rc.6 rollout.packages/rs-drive/Cargo.toml (1)
4-4: Consistent version bump to 2.0.0-rc.6
Updated the Drive crate version to rc.6, matching the synchronized release across Rust packages.packages/token-history-contract/Cargo.toml (1)
4-4: Consistent version bump to 2.0.0-rc.6
Updated the token-history-contract crate to the new release candidate version.packages/feature-flags-contract/Cargo.toml (1)
4-4: Consistent version bump to 2.0.0-rc.6
Updated the feature-flags-contract crate version to rc.6 in line with the global bump.packages/wasm-dpp/Cargo.toml (1)
3-3: Consistent version bump to 2.0.0-rc.6
Updated the wasm-dpp crate to the release candidate 6 version.packages/rs-platform-version/Cargo.toml (1)
5-5:✅ Verification successful
Approve version bump to 2.0.0-rc.6.
The package version has been correctly updated from
2.0.0-rc.5to2.0.0-rc.6. Ensure no stale references to the previous release candidate remain across the codebase.Run the following script to verify that no occurrences of
"2.0.0-rc.5"remain:
🏁 Script executed:
#!/bin/bash # Verify no stale rc.5 references remain rg -n '2.0.0-rc\.5'Length of output: 21
Approve version bump to 2.0.0-rc.6
No remaining references to
2.0.0-rc.5were found after running:rg -n '2.0.0-rc\.5'All clear—merging this change.
packages/strategy-tests/Cargo.toml (1)
3-3: Approve version bump to 2.0.0-rc.6.Consistent with the coordinated bump; no other modifications detected.
packages/rs-platform-value/Cargo.toml (1)
5-5: Approve version bump to 2.0.0-rc.6.Version updated correctly and matches the rest of the workspace.
packages/data-contracts/Cargo.toml (1)
4-4: Approve version bump to 2.0.0-rc.6.Release candidate version increment is accurate. Path-based dependencies will pick up the updated version accordingly.
packages/masternode-reward-shares-contract/Cargo.toml (1)
4-4: Approve version bump to 2.0.0-rc.6.Valid update aligning with the rc.5→rc.6 bump across the repository. Good to merge.
packages/js-dapi-client/package.json (1)
3-3:✅ Verification successful
Version bump to 2.0.0-rc.6 approved
The package version has been correctly updated. Ensure that the corresponding Git tag (v2.0.0-rc.6) and changelog entry are in place.
🏁 Script executed:
#!/bin/bash # Verify no remaining rc.5 references across JSON and TOML files rg -l '"2\.0\.0-rc\.5"' -g '*.json' -g '*.toml'Length of output: 49
Version bump to 2.0.0-rc.6 confirmed
- No remaining references to “2.0.0-rc.5” across JSON/TOML files.
- Ensure the Git tag
v2.0.0-rc.6and an appropriate changelog entry are in place.packages/check-features/Cargo.toml (1)
3-3: Version bump to 2.0.0-rc.6 approved
The crate version has been updated to2.0.0-rc.6as part of the coordinated release.packages/js-grpc-common/package.json (1)
3-3: Version bump to 2.0.0-rc.6 approved
The version has been correctly incremented to2.0.0-rc.6.packages/wallet-lib/package.json (1)
3-3: Version bump to 9.0.0-rc.6 approved
The version update to9.0.0-rc.6aligns with the overall release candidate bump.packages/simple-signer/Cargo.toml (1)
3-3: Version bump to 2.0.0-rc.6 approved
The crate version has been updated consistently with the other packages.packages/dpns-contract/Cargo.toml (2)
4-4: Approve version bump for dpns-contract.
Theversionfield has been correctly updated from2.0.0-rc.5to2.0.0-rc.6in line with the PR objective of bumping release metadata only.
1-14:✅ Verification successful
Verify no lingering
rc.5references.
To ensure consistency across the repo, run this script to confirm there are no leftover2.0.0-rc.5occurrences:
🏁 Script executed:
#!/bin/bash # Search for any old rc.5 references in the repository rg -l '"2.0.0-rc.5"'Length of output: 22
🏁 Script executed:
#!/bin/bash # Search for any references to the exact old version string rg -n '2\.0\.0-rc\.5' # Additionally catch any loose “rc.5” occurrences across the repo rg -n 'rc\.5'Length of output: 393
No remaining “2.0.0-rc.5” references
The search only returnedrc.5in unrelated contexts (e.g.,0.25.16-rc.5in Dashmate configs and CHANGELOG.md). There are no lingering2.0.0-rc.5entries, so the bump to2.0.0-rc.6inpackages/dpns-contract/Cargo.tomlis consistent.packages/dashmate/package.json (1)
3-3: Approve version bump for dashmate.
Theversionfield has been correctly updated to2.0.0-rc.6. No other metadata changes detected.packages/rs-platform-serialization/Cargo.toml (1)
5-5: Approve version bump for platform-serialization.
Theversionhas been correctly incremented to2.0.0-rc.6, matching the coordinated release-candidate update.packages/wallet-utils-contract/Cargo.toml (2)
4-4: Approve version bump for wallet-utils-contract.
Version updated to2.0.0-rc.6as expected, with no unintended modifications to dependencies or metadata.
1-14:✅ Verification successful
Verify JS manifest counterpart.
Ensure that the JavaScriptpackage.jsonin thewallet-utils-contractdirectory also has its version field updated to2.0.0-rc.6. You can run:
🏁 Script executed:
#!/bin/bash # Locate the JS manifest and check its version fd package.json packages/wallet-utils-contract --exec grep -H '"version": "2.0.0-rc.6"'Length of output: 160
JS package.json version matches Cargo.toml
Confirmed thatpackages/wallet-utils-contract/package.jsonhas"version": "2.0.0-rc.6". No further changes needed.packages/rs-platform-value-convertible/Cargo.toml (1)
5-5: Approve version bump for platform-value-convertible.
Theversionfield is correctly set to2.0.0-rc.6, completing the coordinated version alignment.packages/dashpay-contract/Cargo.toml (1)
4-4: Confirm version bump to 2.0.0-rc.6
Theversionfield has been correctly updated from2.0.0-rc.5to2.0.0-rc.6, matching the coordinated release across the repository. No other metadata changes detected.packages/rs-platform-serialization-derive/Cargo.toml (1)
5-5: Confirm version bump to 2.0.0-rc.6
Theversionfield has been correctly updated to2.0.0-rc.6, in line with the monorepo release strategy. No additional modifications required in this manifest.packages/withdrawals-contract/Cargo.toml (1)
4-4: Confirm version bump to 2.0.0-rc.6
Updated the crate version from2.0.0-rc.5to2.0.0-rc.6as part of the unified release. Everything else remains unchanged.packages/withdrawals-contract/package.json (1)
3-3: Confirm version bump to 2.0.0-rc.6
Theversionfield has been incremented to2.0.0-rc.6, consistent with the PR objective. No other metadata or dependency changes found.packages/wallet-utils-contract/package.json (1)
3-3: Confirm version bump to 2.0.0-rc.6
Bumped the package version to2.0.0-rc.6in alignment with the coordinated release. No further changes necessary.packages/js-dash-sdk/package.json (1)
3-3: Version bump to 5.0.0-rc.6 is correct for the Dash JS SDK.Matches the coordinated version upgrade across the ecosystem.
packages/dapi/package.json (1)
4-4: Version bump to 2.0.0-rc.6 is correct for @dashevo/dapi.Private package version aligned with the RC6 release.
packages/masternode-reward-shares-contract/package.json (1)
3-3: Version bump to 2.0.0-rc.6 is correct for @dashevo/masternode-reward-shares-contract.Consistent with the overall platform versioning strategy.
packages/platform-test-suite/package.json (1)
4-4: Version bump to 2.0.0-rc.6 is correct for @dashevo/platform-test-suite.Private test suite version updated to RC6 as expected.
packages/dpns-contract/package.json (1)
3-3: Consistent version bump to 2.0.0-rc.6
Theversionfield has been correctly updated from2.0.0-rc.5to2.0.0-rc.6. No other metadata or dependencies were altered.packages/feature-flags-contract/package.json (1)
3-3: Consistent version bump to 2.0.0-rc.6
Theversionfield has been correctly updated from2.0.0-rc.5to2.0.0-rc.6. All other entries remain unchanged.packages/rs-dpp/Cargo.toml (1)
3-3: Consistent version bump to 2.0.0-rc.6
Theversionin the[package]section is correctly updated from2.0.0-rc.5to2.0.0-rc.6. All dependencies and features are unchanged.packages/dashpay-contract/package.json (1)
3-3: Consistent version bump to 2.0.0-rc.6
Updated theversionfield from2.0.0-rc.5to2.0.0-rc.6. No other changes detected.packages/bench-suite/package.json (1)
4-4: Consistent version bump to 2.0.0-rc.6
Theversionproperty has been correctly incremented from2.0.0-rc.5to2.0.0-rc.6. Everything else is intact.package.json (1)
3-3: Approve version bump to 2.0.0-rc.6
The version field has been updated correctly to RC 6. This aligns with the coordinated release across all packages.packages/dapi-grpc/Cargo.toml (1)
4-4: Approve version bump to 2.0.0-rc.6
Theversionentry has been updated from RC 5 to RC 6, matching the repository-wide release candidate update.packages/rs-dapi-grpc-macros/Cargo.toml (1)
4-4: Approve version bump to 2.0.0-rc.6
The macro crate’s version has been bumped in line with the platform’s RC 6 release.packages/dapi-grpc/package.json (1)
3-3: Approve version bump to 2.0.0-rc.6
The package manifest version is correctly updated to RC 6, consistent with the overall release.
bump to rc.6
Summary by CodeRabbit