chore(platform): bump rust dashcore version to 0.39.6 #2553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis change updates the Dash Core Rust library dependencies across several packages by bumping the version from Changes
Sequence Diagram(s)Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (19)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
QuantumExplorer
changed the title
QuantumExplorer
approved these changes
Apr 17, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
packages/rs-dpp/Cargo.toml(1 hunks)packages/rs-drive-abci/Cargo.toml(1 hunks)packages/rs-sdk/Cargo.toml(1 hunks)packages/simple-signer/Cargo.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
packages/rs-drive-abci/Cargo.toml (1)
Learnt from: shumkov
PR: dashpay/platform#2375
File: packages/rs-drive-abci/Cargo.toml:61-63
Timestamp: 2024-12-05T09:29:38.918Z
Learning: In the `drive-abci` package, avoid adding unused dependencies like `hashbrown` to `Cargo.toml`. The team relies on CI to detect dependency version issues.
⏰ Context from checks skipped due to timeout of 90000ms (15)
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Rust packages (wasm-dpp) / Linting
- GitHub Check: Rust packages (wasm-dpp) / Tests
- GitHub Check: Rust packages (dpp) / Unused dependencies
- GitHub Check: Rust packages (dpp) / Formatting
- GitHub Check: Rust packages (dpp) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust crates security audit
🔇 Additional comments (3)
packages/rs-drive-abci/Cargo.toml (1)
31-31: Bumpdashcoredependency to v0.39.6
This updates the Git tag for the Dash Core Rust library in this package fromv0.39.5tov0.39.6, ensuring consistency across all Rust components.packages/rs-dpp/Cargo.toml (1)
31-31:❓ Verification inconclusive
Bump dashcore dependency to v0.39.6
Thedashcorecrate has been updated fromv0.39.5tov0.39.6, matching other packages’ bump. This is a patch‐level upgrade, so it should be backwards compatible, but please confirm that no unexpected changes in features or APIs were introduced and that the crate still builds and all tests pass.Run the following to validate the bump:
🏁 Script executed:
#!/bin/bash # Verify that dashcore v0.39.6 builds and tests pass in rs-dpp cd packages/rs-dpp cargo update -p dashcore --precise v0.39.6 cargo testLength of output: 270
Bump dashcore dependency to v0.39.6
- packages/rs-dpp/Cargo.toml: updated
dashcoretag fromv0.39.5tov0.39.6.- This is a patch‑level upgrade and should remain backwards compatible, but please verify no API or feature changes slipped in.
Please confirm locally that the crate still builds and all tests pass:
cd packages/rs-dpp cargo update -p dashcore --precise v0.39.6 cargo testpackages/rs-sdk/Cargo.toml (1)
41-41:✅ Verification successful
Verify the updated
dashcore-rpcdependency version and naming
The tag has been bumped tov0.39.6here, but other packages migrated fromdashcore-rpctodashcore. Please:
- Confirm that the
v0.39.6tag exists in the remote repo.- Ensure that the crate is still named
dashcore-rpcin its Cargo.toml (or consider renaming todashcorefor consistency).
🏁 Script executed:
#!/bin/bash # Verify existence of v0.39.6 tag in the rust-dashcore repository git ls-remote --tags https://github.com/dashpay/rust-dashcore | grep 'refs/tags/v0.39.6'Length of output: 147
🏁 Script executed:
#!/bin/bash # Fetch the Cargo.toml for v0.39.6 and verify the crate name curl -sL https://raw.githubusercontent.com/dashpay/rust-dashcore/v0.39.6/Cargo.toml | grep '^name ='Length of output: 102
🏁 Script executed:
#!/bin/bash # Fetch the root Cargo.toml for v0.39.6 and verify the crate `name` entry curl -sL https://raw.githubusercontent.com/dashpay/rust-dashcore/v0.39.6/Cargo.toml | grep -E '^\s*name\s*='Length of output: 110
🏁 Script executed:
#!/bin/bash # Clone the v0.39.6 tag of rust-dashcore and list all crate names git clone --depth 1 --branch v0.39.6 https://github.com/dashpay/rust-dashcore /tmp/rust-dashcore grep -R '^\s*name\s*=' /tmp/rust-dashcore --include "Cargo.toml"Length of output: 3609
Confirmed
dashcore-rpcv0.39.6 tag and crate name – no changes needed
- Upstream tag
v0.39.6exists in https://github.com/dashpay/rust-dashcore (commit 51df58f5d5d4).- The
rpc-client/Cargo.tomlin that tag declaresname = "dashcore-rpc"(with an internal lib targetdashcore_rpc), so the dependency lineis correct as-is.dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", tag = "v0.39.6" }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit