Skip to content

Conversation

@QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Apr 14, 2025

Issue being fixed or feature implemented

Tonic 0.12 used an old version of tower that itself had an old version of index map that was broken for light clients. We used patches to deal with this up till now. Tonic 0.13 was recently released so the headache can finally go away.

What was done?

Updated tonic and a few other dependencies.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores

    • Removed a legacy dependency override to simplify configuration.
    • Upgraded numerous internal libraries—including error handling, serialization, and network components—to their latest versions for improved reliability and performance.
    • Extended feature configurations in one module to support additional functionality.
  • Refactor

    • Enhanced error message formatting for timeout events to boost clarity.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 14, 2025

Walkthrough

This pull request removes a [patch.crates-io] section from the root Cargo.toml that previously overrode the versions for tower-related crates. In addition, many package manifests have been updated to bump dependency versions (e.g., upgrading thiserror, serde, serde_json, tonic, dashcore-rpc, and others) and adjust commit references. A source file was also modified to improve error message formatting. Overall, the changes update dependency configurations and ensure consistency across multiple packages.

Changes

File(s) Change Summary
Cargo.toml Removed the [patch.crates-io] section for tower-service, tower-layer, and tower.
packages/dapi-grpc/Cargo.toml Updated the server feature to add "tonic/router", changed tenderdash-proto from a version to a commit revision, and bumped tonic/tonic-build from 0.12.30.13.0 and serde from 1.0.1971.0.219.
packages/{dashpay-contract, data-contracts, dpns-contract, feature-flags-contract, masternode-reward-shares-contract, search-contract, token-history-contract, wallet-utils-contract}/Cargo.toml Upgraded thiserror from 1.0.64 to 2.0.12.
packages/rs-dapi-client/Cargo.toml Upgraded thiserror (1.0.642.0.12), serde (1.0.1971.0.219), and serde_json (1.0.1201.0.140).
packages/rs-dpp/Cargo.toml Updated dashcore tag from v0.38.0 to v0.39.3, serde (1.0.1971.0.219), and thiserror (from 1.0 to 2.0.12).
packages/rs-drive-abci/Cargo.toml Upgraded serde, changed dashcore-rpc tag from v0.38.0 to v0.39.3, and modified tenderdash-abci to use a specific commit revision.
packages/rs-drive-proof-verifier/Cargo.toml Upgraded thiserror (1.0.632.0.12), serde (1.0.1971.0.219), serde_json (1.0.1031.0), and updated tenderdash-abci to reference a commit (rev).
packages/rs-drive/Cargo.toml Upgraded thiserror (1.0.632.0.12), serde (1.0.1971.0.219), and updated multiple grovedb dependencies with a new commit hash.
packages/rs-json-schema-compatibility-validator/Cargo.toml Updated serde_json from 1.0.115 to "1.0" and thiserror from 1.0.64 to 2.0.12.
packages/rs-platform-value/Cargo.toml Upgraded thiserror (1.0.642.0.12) and serde (1.0.1971.0.219).
packages/rs-platform-version/Cargo.toml Upgraded thiserror (1.0.632.0.12) and updated the grovedb-version revision to a new commit hash.
packages/rs-sdk/Cargo.toml Upgraded thiserror (1.0.642.0.12), serde (1.0.1971.0.219), and dashcore-rpc tag from v0.38.0 to v0.39.3.
packages/rs-sdk/src/error.rs Modified error message formatting for the TimeoutReached variant in the Error enum to include both parameters correctly.
packages/simple-signer/Cargo.toml Updated dashcore-rpc tag from v0.38.0 to v0.39.3.
packages/wasm-dpp/Cargo.toml Upgraded serde (1.0.1971.0.219) and thiserror (from 1.0.63 to 2.0.12).
packages/wasm-sdk/Cargo.toml Updated thiserror from 2.0.9 to 2.0.12.
packages/withdrawals-contract/Cargo.toml Upgraded thiserror (1.0.642.0.12) and serde (1.0.1971.0.219).

Possibly related PRs

Suggested reviewers

  • shumkov

Poem

I’m a rabbit hopping through the code,
Updates and upgrades lightening my load.
From patches gone to errors refined,
Dependencies now perfectly aligned.
With every commit, my heart leaps high—
A code bunny’s joy under the starry sky!
🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3f1347 and 29ca17d.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • packages/rs-dapi-client/Cargo.toml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/rs-dapi-client/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms (18)
  • GitHub Check: Rust packages (drive-abci) / Tests
  • GitHub Check: Rust packages (drive-abci) / Check each feature
  • GitHub Check: Rust packages (drive-abci) / Linting
  • GitHub Check: Rust packages (wasm-dpp) / Formatting
  • GitHub Check: Rust packages (drive) / Unused dependencies
  • GitHub Check: Rust packages (drive) / Linting
  • GitHub Check: Rust packages (wasm-dpp) / Tests
  • GitHub Check: Rust packages (drive) / Tests
  • GitHub Check: Rust packages (withdrawals-contract) / Detect immutable structure changes
  • GitHub Check: Rust packages (withdrawals-contract) / Tests
  • GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
  • GitHub Check: Rust packages (dpp) / Tests
  • GitHub Check: Rust packages (withdrawals-contract) / Linting
  • GitHub Check: Rust packages (dpp) / Check each feature
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build JS packages / Build JS

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@QuantumExplorer QuantumExplorer added this to the v2.0.0 milestone Apr 14, 2025
@QuantumExplorer QuantumExplorer merged commit 2c59bd0 into v2.0-dev Apr 14, 2025
387 of 389 checks passed
@QuantumExplorer QuantumExplorer deleted the chore/updateTonic branch April 14, 2025 09:30
@coderabbitai coderabbitai bot mentioned this pull request Sep 25, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants