Skip to content

test: unify identity versioned cost coverage #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 12, 2025
Merged

test: unify identity versioned cost coverage #2416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
141f018
test: added version checks when checking fee results
QuantumExplorer Jan 11, 2025
1ee0c25
test: improved insert identity tests
QuantumExplorer Jan 11, 2025
f7364ec
added some extra cost tests
QuantumExplorer Jan 12, 2025
23cf69b
improved more tests
QuantumExplorer Jan 12, 2025
05c14b6
fix
QuantumExplorer Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 77 additions & 78 deletions packages/rs-drive/src/drive/document/insert/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,78 +315,86 @@ mod tests {
}

#[test]
fn test_add_dashpay_profile_with_fee() {
let drive = setup_drive_with_initial_state_structure(None);
fn test_add_dashpay_profile_with_fee_first_version_apply() {
let platform_version = PlatformVersion::first();
let expected_fee_result = FeeResult {
storage_fee: 1305
* Epoch::new(0).unwrap().cost_for_known_cost_item(
&EPOCH_CHANGE_FEE_VERSION_TEST,
StorageDiskUsageCreditPerByte,
),
processing_fee: 900400,
..Default::default()
};

do_test_add_dashpay_profile_with_fee(true, platform_version, expected_fee_result);
}

let db_transaction = drive.grove.start_transaction();
#[test]
fn test_add_dashpay_profile_with_fee_first_version_estimated() {
let platform_version = PlatformVersion::first();
let expected_fee_result = FeeResult {
storage_fee: 1305
* Epoch::new(0).unwrap().cost_for_known_cost_item(
&EPOCH_CHANGE_FEE_VERSION_TEST,
StorageDiskUsageCreditPerByte,
),
processing_fee: 73253660,
..Default::default()
};

do_test_add_dashpay_profile_with_fee(false, platform_version, expected_fee_result);
}

#[test]
fn test_add_dashpay_profile_with_fee_latest_version_apply() {
let platform_version = PlatformVersion::latest();

let contract = setup_contract(
&drive,
"tests/supporting_files/contract/dashpay/dashpay-contract.json",
None,
Some(&db_transaction),
);

let document_type = contract
.document_type_for_name("profile")
.expect("expected to get document type");

let random_owner_id = rand::thread_rng().gen::<[u8; 32]>();

let dashpay_profile_document = json_document_to_document(
"tests/supporting_files/contract/dashpay/profile0.json",
Some(random_owner_id.into()),
document_type,
platform_version,
)
.expect("expected to get cbor document");

let fee_result = drive
.add_document_for_contract(
DocumentAndContractInfo {
owned_document_info: OwnedDocumentInfo {
document_info: DocumentRefInfo((
&dashpay_profile_document,
StorageFlags::optional_default_as_cow(),
)),
owner_id: Some(random_owner_id),
},
contract: &contract,
document_type,
},
false,
BlockInfo::default(),
true,
Some(&db_transaction),
platform_version,
None,
)
.expect("expected to insert a document successfully");

assert_eq!(
fee_result,
FeeResult {
storage_fee: 1305
* Epoch::new(0).unwrap().cost_for_known_cost_item(
&EPOCH_CHANGE_FEE_VERSION_TEST,
StorageDiskUsageCreditPerByte,
),
processing_fee: 900400,
..Default::default()
}
);
let expected_fee_result = FeeResult {
storage_fee: 1305
* Epoch::new(0).unwrap().cost_for_known_cost_item(
&EPOCH_CHANGE_FEE_VERSION_TEST,
StorageDiskUsageCreditPerByte,
),
processing_fee: 900400,
..Default::default()
};

do_test_add_dashpay_profile_with_fee(true, platform_version, expected_fee_result);
}

#[test]
fn test_add_dashpay_profile_average_case_cost_fee() {
fn test_add_dashpay_profile_with_fee_latest_version_estimated() {
let platform_version = PlatformVersion::latest();
let expected_fee_result = FeeResult {
storage_fee: 1305
* Epoch::new(0).unwrap().cost_for_known_cost_item(
&EPOCH_CHANGE_FEE_VERSION_TEST,
StorageDiskUsageCreditPerByte,
),
processing_fee: 73253660,
..Default::default()
};

do_test_add_dashpay_profile_with_fee(false, platform_version, expected_fee_result);
}

/// This helper sets up the environment, adds a dashpay profile document,
/// and either applies or just estimates the cost.
///
/// `apply`: if true, we commit the transaction (applying the changes).
/// if false, we do not commit, so changes are only estimated.
/// `platform_version`: which PlatformVersion to use.
/// `expected_fee_result`: the FeeResult we expect in the test assertion.
fn do_test_add_dashpay_profile_with_fee(
apply: bool,
platform_version: &PlatformVersion,
expected_fee_result: FeeResult,
) {
let drive = setup_drive_with_initial_state_structure(None);

let db_transaction = drive.grove.start_transaction();

let platform_version = PlatformVersion::latest();

// Setup contract
let contract = setup_contract(
&drive,
"tests/supporting_files/contract/dashpay/dashpay-contract.json",
Expand All @@ -398,8 +406,9 @@ mod tests {
.document_type_for_name("profile")
.expect("expected to get document type");

let random_owner_id = rand::thread_rng().gen::<[u8; 32]>();
let random_owner_id = random::<[u8; 32]>();

// Build dashpay profile doc
let dashpay_profile_document = json_document_to_document(
"tests/supporting_files/contract/dashpay/profile0.json",
Some(random_owner_id.into()),
Expand All @@ -408,12 +417,8 @@ mod tests {
)
.expect("expected to get cbor document");

let FeeResult {
storage_fee,
processing_fee,
fee_refunds: _,
removed_bytes_from_system: _,
} = drive
// Perform the add operation, with either an apply or a dry run
let fee_result = drive
.add_document_for_contract(
DocumentAndContractInfo {
owned_document_info: OwnedDocumentInfo {
Expand All @@ -426,22 +431,16 @@ mod tests {
contract: &contract,
document_type,
},
false,
false, // override
BlockInfo::default(),
false,
apply,
Some(&db_transaction),
platform_version,
None,
)
.expect("expected to insert a document successfully");

let added_bytes = storage_fee
/ Epoch::new(0).unwrap().cost_for_known_cost_item(
&EPOCH_CHANGE_FEE_VERSION_TEST,
StorageDiskUsageCreditPerByte,
);
assert_eq!(1305, added_bytes);
assert_eq!(73253660, processing_fee);
assert_eq!(fee_result, expected_fee_result);
}

#[test]
Expand Down
Loading
Loading