feat(sdk)!: allow setting CA cert to use when connecting to dapi servers #1924
+257,376
−96,355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Paul DeLucia <[email protected]>
Co-authored-by: lklimek <[email protected]>
fominok
reviewed
Aug 19, 2024
| /// | ||
| /// This is a convenience method that reads the certificate from a file and sets it using | ||
| /// [SdkBuilder::with_ca_certificate()]. | ||
| pub fn with_ca_certificate_file( |
There was a problem hiding this comment.
I think a better approach would be to have just a single with_ca_certificate and expect an actual certificate value, users can figure out where and how to get it as long as it can be constructed
Co-authored-by: Odysseas Gabrielides <[email protected]>
Co-authored-by: Ivan Shumkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
To intercept traffic, I use mitmproxy.
However, it doesn't support http/3 without tls, and to work with tls I need to set ca certificate inside SDK.
What was done?
Developers can use
SdkBuilder::with_ca_certificateto provide CA certificate to use when verifying DAPI certificates.Added CA cert to DapiClient and AppliedRequestSettings.
This means that AppliedRequestSettings no longer implements Copy trait.
How Has This Been Tested?
DASH_SDK_PLATFORM_SSL=truebut no SSL certcargo test -p dash-sdk --no-default-features -F network-testing test_data_contract_read_not_found; result: errorDASH_SDK_PLATFORM_CA_CERT_PATH=/path/to/mitmproxy/cacrt.pemcargo test -p dash-sdk --no-default-features -F network-testing test_data_contract_read_not_found; result: OKBreaking Changes
AppliedRequestSettings have one additional field that must be filled (can be
None).AppliedRequestSettings no longer implement Copy trait.
Checklist:
For repository code-owners and collaborators only