-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(dashmate)!: speedup dashmate command #1916
Open
shumkov
wants to merge
324
commits into
master
Choose a base branch
from
perf/dashmate-startup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: thephez <[email protected]>
# Conflicts: # packages/dashmate/src/listr/tasks/setup/setupRegularPresetTaskFactory.js
Temporary disabled due to flakiness. These tests aren't important for now, since we are // going to release v1.0.0 with withdrawals disabled.
Temporary disabled due to flakiness. These tests aren't important for now, since we are // going to release v1.0.0 with withdrawals disabled.
Co-authored-by: thephez <[email protected]>
# Conflicts: # packages/dashmate/src/listr/tasks/setup/setupLocalPresetTaskFactory.js # packages/dashmate/src/listr/tasks/setup/setupRegularPresetTaskFactory.js
# Conflicts: # packages/platform-test-suite/test/e2e/withdrawals.spec.js # scripts/configure_dotenv.sh # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Dashmate commands are very slow which is very annoying in day-to-day use. The most time is taken by yarn and importing modules (not actual work).
What was done?
dashmate/src/index.js
) to allow bundling@dashevo/utils
dependency fromdash-spv
due to tons of deprecation warnings after bundling./scripts/dashmate
to avoid of usingyarn ..
to run scripts, which was 20% slower@oclif/plugin-help
which needs to generate extended help for commands (development purposes)DEBUG=\*
env is passedHow Has This Been Tested?
Breaking Changes
It shouldn't be any difference for end user, but developers needs to know:
yarn dashmate ..
now you need to use./scripts/dashmate
from the platform repo root.yarn build
). During dashmate development, it is better to call it frompackages/dashmate
so you won't constantly rebuild everything.Checklist:
For repository code-owners and collaborators only