Skip to content

Conversation

ogabrielides
Copy link
Contributor

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

shotonoff and others added 30 commits July 7, 2023 12:33
…n-block' into statesync-create-snapshot-every-n-block
…n-block' into statesync-create-snapshot-every-n-block
…n-block' into statesync-create-snapshot-every-n-block
@ogabrielides ogabrielides marked this pull request as draft May 27, 2024 16:18
@ogabrielides ogabrielides changed the title Feat: state sync feat: state sync May 30, 2024
&self.snapshot_fetching_session
}

fn platform(&self) -> &'p Platform<C> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform already defined with PlatformApplication

Copy link
Contributor Author

@ogabrielides ogabrielides Jun 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shumkov handler apply_snapshot_chunk requires that app must implement SnapshotManagerApplication and SnapshotFetchingApplication and not PlatformApplication. (@fominok can explain why)

@shumkov shumkov changed the base branch from v1.0-dev to master August 25, 2024 06:05
@ogabrielides
Copy link
Contributor Author

closing at it will be included in #2413

@ogabrielides ogabrielides deleted the feat/state-sync branch January 8, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.