-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: should always use manually-installed llvm, regardless of platform #1717
Open
coolaj86
wants to merge
48
commits into
dashpay:master
Choose a base branch
from
dashhive:fix-wasm-dpp-script
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41,970
−14,258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ivan Shumkov <[email protected]>
…-check (dashpay#1647) Co-authored-by: Ivan Shumkov <[email protected]>
…ommitted (dashpay#1663) Co-authored-by: Quantum Explorer <[email protected]>
Co-authored-by: QuantumExplorer <[email protected]>
Co-authored-by: QuantumExplorer <[email protected]>
Co-authored-by: Odysseas Gabrielides <[email protected]> Co-authored-by: Ivan Shumkov <[email protected]>
Co-authored-by: Odysseas Gabrielides <[email protected]> Co-authored-by: Ivan Shumkov <[email protected]>
Co-authored-by: Djavid Gabibiyan <[email protected]> Co-authored-by: Dmitrii Golubev <[email protected]> Co-authored-by: strophy <[email protected]> Co-authored-by: QuantumExplorer <[email protected]> Co-authored-by: fominok <[email protected]> Co-authored-by: Ivan Shumkov <[email protected]> Co-authored-by: markin.io <[email protected]>
… attacks (dashpay#1681) Co-authored-by: markin.io <[email protected]> Co-authored-by: Lukasz Klimek <[email protected]> Co-authored-by: Ivan Shumkov <[email protected]>
dashpay#1705) Co-authored-by: Quantum Explorer <[email protected]>
Co-authored-by: QuantumExplorer <[email protected]>
I finished testing on macOS to confirm that the AR and CC variables are NOT necessary (no xcode magic alias trickery). |
8ea23aa
to
d0e6d1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This use of command prefixes is redundant since
command -v clang
is just looking upclang
in the user'sPATH
- which is what typing theclang
command will do already, except in situations where there's a shell function or alias calledclang
(which is not the case on macOS or Linux).Also, clang must be installed via the official tarball regardless of macOS or Linux.
Issue being fixed or feature implemented
Just documenting behavior.
What was done?
Documented that llvm must be installed manually (regardless of mac vs linux).
Removed redundant (and potentially confusing) use of
command -v
to define a command that's already in the user'sPATH
.How Has This Been Tested?
clang
won't build these tools, but the official version will.See
v1.0-dev
(the current working branch) fails to build from source #1712.(tested on a fresh install via UTM virtual machine)
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only