Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should always use manually-installed llvm, regardless of platform #1717

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

fix: should always use manually-installed llvm, regardless of platform #1717

wants to merge 48 commits into from
+41,970 −14,258

Conversation

coolaj86
Copy link

@coolaj86 coolaj86 commented Feb 26, 2024 •
edited

This use of command prefixes is redundant since command -v clang is just looking up clang in the user's PATH - which is what typing the clang command will do already, except in situations where there's a shell function or alias called clang (which is not the case on macOS or Linux).

Also, clang must be installed via the official tarball regardless of macOS or Linux.

Issue being fixed or feature implemented

Just documenting behavior.

What was done?

Documented that llvm must be installed manually (regardless of mac vs linux).

Removed redundant (and potentially confusing) use of command -v to define a command that's already in the user's PATH.

How Has This Been Tested?

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

lklimek and others added 30 commits November 27, 2023 12:53
@lklimek
chore: automatic clippy fixes (dashpay#1528)
5b4e232
@lklimek
chore: cargo clippy fixes, continued (dashpay#1602)
28820ae
@lklimek
feat(sdk): rs-sdk fetch current epoch (dashpay#1604)
13243e9
@shumkov
Merge branch 'master' into v1.0-dev
f801f61
@QuantumExplorer
Merge branch 'master' into v1.0-dev
5bd7a58
@QuantumExplorer
feat(drive-abci)!: processing fees for signature verification (dashpa…
becabaf 
…y#1656)
@QuantumExplorer @shumkov
fix(platform)!: credit transfer replay attack (dashpay#1634)
d177116 
Co-authored-by: Ivan Shumkov <[email protected]>
@shumkov
feat(drive-abci)!: include invalid state transitions into block (dash…
ea27d6a 
…pay#1657)
@QuantumExplorer @shumkov
feat(drive-abci)!: remove unnecessary validation from check tx and re…
c47aed4 
…-check (dashpay#1647)

Co-authored-by: Ivan Shumkov <[email protected]>
@shumkov
fix(dapi): internal error when mempool is full (dashpay#1661)
8ad118f
@shumkov
chore(release): update change log and versions to 1.0.0-dev.1 (dashpa…
c9b2927 
…y#1662)
@shumkov
chore(drive-abci): fix state transition logging (dashpay#1664)
9b24a19
@shumkov @QuantumExplorer
fix(drive-abci)!: internal error if vote extension block is already c…
49586bf 
…ommitted (dashpay#1663)

Co-authored-by: Quantum Explorer <[email protected]>
@shumkov
fix: broadcasting already invalidated transitions (dashpay#1668)
f21ea2f
@shumkov @QuantumExplorer
chore: various logging improvements (dashpay#1666)
b3f0114 
Co-authored-by: QuantumExplorer <[email protected]>
@shumkov
chore(dashmate)!: adjust consensus params and enable re-check (dashpa…
31f84e4 
…y#1669)
@shumkov
fix(dashmate): dapi kills host machine on container stop (dashpay#1670)
d320578
@shumkov
chore(release): update changelog and bump version to 1.0.0-dev.2 (das…
535429a 
…hpay#1671)
@shumkov
fix(dapi): internal errors if broadcasting failed (dashpay#1673)
77febff
@shumkov
chore(release): update changelog and bump version to 1.0.0-dev.3 (das…
2c0c579 
…hpay#1674)
@markin-io
chore(dashmate): update to core v20.1.0-devpr5806.a1814ce2 (dashpay#1665
f8c88f3 
)
@markin-io @QuantumExplorer
feat(drive): validate asset lock proof minimal value (dashpay#1667)
30929ea 
Co-authored-by: QuantumExplorer <[email protected]>
@shumkov
fix(drive): invalid protocol version is using to deserialize state (d…
26e775f 
…ashpay#1679)
@QuantumExplorer @ogabrielides @shumkov
feat!: chainlock optimized verification (dashpay#1621)
20b39d6 
Co-authored-by: Odysseas Gabrielides <[email protected]>
Co-authored-by: Ivan Shumkov <[email protected]>
@shumkov
chore: system data contracts versioning (dashpay#1676)
6b8df26
@pshenmic
fix(dashmate): service status when tenderdash is syncing (dashpay#1682)
0e78075
@lklimek
chore: update rs-tenderdash-abci to v0.14.0-dev.6 and tenderdash to v…
63e5366 
…0.14.0-dev.2 (dashpay#1686)
@markin-io @ogabrielides @shumkov
feat(drive): withdrawals finalization (dashpay#1601)
9591752 
Co-authored-by: Odysseas Gabrielides <[email protected]>
Co-authored-by: Ivan Shumkov <[email protected]>
@shumkov
chore(release): update changelog and bump version to 1.0.0-dev.4 (das…
bf8e7b4 
…hpay#1688)
@QuantumExplorer
refactor(platform): autogenerated clippy fixes for rust version 1.76 (d…
7fc1cd9 
…ashpay#1691)
QuantumExplorer and others added 17 commits February 9, 2024 08:36
@QuantumExplorer
chore: remove anton as code owner
865ed22
@lklimek
build: bump protoc to 25.2 (dashpay#1692)
c97922f
@lklimek @jawid-h
@shotonoff @strophy @QuantumExplorer @fominok @shumkov @markin-io
feat(sdk): state transitions support in rust sdk (dashpay#1596)
5a145d5 
Co-authored-by: Djavid Gabibiyan <[email protected]>
Co-authored-by: Dmitrii Golubev <[email protected]>
Co-authored-by: strophy <[email protected]>
Co-authored-by: QuantumExplorer <[email protected]>
Co-authored-by: fominok <[email protected]>
Co-authored-by: Ivan Shumkov <[email protected]>
Co-authored-by: markin.io <[email protected]>
@markin-io
refactor(drive): remove min core fee per byte check (dashpay#1690)
2feb87e
@fominok
fix: proof balance and revision for IdentityTopUp (dashpay#1678)
2848340
@QuantumExplorer
fix(platform): remove ability to verify proofs from drive-abci (dashp…
c3d4e7f 
…ay#1699)
@shumkov
fix: npm IP package vulnerable to SSRF attacks (dashpay#1703)
71acab7
@shumkov
feat(dashmate): tenderdash mempool cache size config option (dashpay#…
b408de7 
…1702)
@markin-io
feat(dpp)!: do not allow creating data contracts without documents (d…
86778be 
…ashpay#1675)
@QuantumExplorer @markin-io
@lklimek @shumkov
feat(platform)!: identity nonce and contract nonces to prevent replay…
724b272 
… attacks (dashpay#1681)

Co-authored-by: markin.io <[email protected]>
Co-authored-by: Lukasz Klimek <[email protected]>
Co-authored-by: Ivan Shumkov <[email protected]>
@QuantumExplorer
chore: bump to version 1.0.0 dev 5 (dashpay#1704)
acce68d
@QuantumExplorer
feat(sdk): fetch with metadata (dashpay#1707)
5b6fc20
@QuantumExplorer
feat(sdk): add fetch_current_with_metadata to ExtendedEpochInfo (dash…
c481783 
…pay#1708)
@markin-io
feat(sdk): re-fetch nonce on interval (dashpay#1706)
541b27e
@pauldelucia @QuantumExplorer
fix: make strategy tests compatible with all networks and platform tui (
a988e69 
dashpay#1705)

Co-authored-by: Quantum Explorer <[email protected]>
@markin-io
fix(test-suite): masternode identities (dashpay#1709)
73f20dc
@markin-io @QuantumExplorer
fix(sdk): nonce manager caching bug (dashpay#1711)
dc03275 
Co-authored-by: QuantumExplorer <[email protected]>
@coolaj86
Copy link
Author

I finished testing on macOS to confirm that the AR and CC variables are NOT necessary (no xcode magic alias trickery).

@shumkov shumkov changed the base branch from v1.0-dev to master August 25, 2024 06:06
@shumkov shumkov requested a review from antouhou as a code owner August 25, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov Awaiting requested review from shumkov shumkov is a code owner

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

@antouhou antouhou Awaiting requested review from antouhou

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@coolaj86 @lklimek @shumkov @QuantumExplorer @markin-io @pshenmic @fominok @pauldelucia