Skip to content

build: disable sccache - #1105

Closed
lklimek wants to merge 3 commits into
v0.25-devfrom
build/disable-sccache
Closed

build: disable sccache#1105
lklimek wants to merge 3 commits into
v0.25-devfrom
build/disable-sccache

Conversation

@lklimek

@lklimek lklimek commented May 18, 2023

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

sccache is not stable enough

What was done?

  • disabled sccache by default, can be re-enabled by setting RUSTC_WRAPPER=sccache
  • updated documentation
  • removed sccache from github workflows and actions
  • re-enabled caching of /target
  • modified Dockerfile to only install and use sccache if it's enabled
  • moved installation of wasm-bindgen-cli to separate stage, to use sccache if it's enabled

How Has This Been Tested?

  • locally with docker buildx build ...
  • github actions

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek
lklimek requested a review from strophy May 18, 2023 15:11
@lklimek
lklimek marked this pull request as ready for review May 18, 2023 15:11
@lklimek
lklimek requested review from antouhou and shumkov as code owners May 18, 2023 15:11
@lklimek lklimek self-assigned this May 19, 2023
@shumkov

shumkov commented May 19, 2023

Copy link
Copy Markdown
Collaborator

I just realized that if we merge it now, everything become super slow. Maybe we should wait until mount cache is ready?

@shumkov shumkov mentioned this pull request Jun 23, 2023
5 tasks
@shumkov

shumkov commented Jun 23, 2023

Copy link
Copy Markdown
Collaborator

Closed in favor of #1167

@shumkov shumkov closed this Jun 23, 2023
@shumkov
shumkov deleted the build/disable-sccache branch June 23, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants