feat: Simple checkpoint - #9
Merged
Merged
Conversation
fominok
force-pushed
the
simple_checkpoint
branch
2 times, most recently
from
December 8, 2021 12:54
2b28812 to
6b53c75
Compare
fominok
marked this pull request as ready for review
December 8, 2021 14:20
QuantumExplorer
requested changes
Dec 20, 2021
fominok
force-pushed
the
abstract_storage
branch
from
December 20, 2021 11:27
8bc4d27 to
f2f388b
Compare
this includes abstracting from rocksdb as well as making merk unaware of prefixes and other details
fominok
force-pushed
the
simple_checkpoint
branch
from
December 20, 2021 11:57
6b53c75 to
e0f38da
Compare
QuantumExplorer
approved these changes
Dec 20, 2021
3 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an ability to make a checkpoint of current GroveDB state, basically by reusing RocksDB checkpointing funcitonality;
Also there is an attempt to deprecate
failurecrate and to do a little cleanup of error handling story