-
Notifications
You must be signed in to change notification settings - Fork 26
feat: counted offset skip for unproved ranked paginated reads #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shumkov
wants to merge
12
commits into
develop
Choose a base branch
from
fix/counted-skip-unproved-read
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
356af1e
docs: record the counted-skip design for unproved ranked reads
shumkov e79f618
feat: counted offset skip for unproved ranked paginated reads
shumkov e41d57e
feat: report the true skipped count from unproved paginated ranked reads
shumkov c37729e
fix: gate the IndexedTopKPage re-export on minimal, not minimal-or-ve…
shumkov cc7b399
test: pin that the unproved skipped equals the proved path's attested…
shumkov c4ceac6
test: cover the legacy baseline and the counted path's returned-row d…
shumkov 0100cb8
fix: serve the whole counted page from one pinned iterator view
shumkov 63df14c
fix: discover the secondary root key inside the counted read's pinned…
shumkov 5085dd8
fix: clamp the counted page's pre-allocation; align doc prose with me…
shumkov 91490a4
test: pin that a dangling secondary root key fails loud through the c…
shumkov c6727c0
Merge develop into fix/counted-skip-unproved-read (post unified-PathQ…
QuantumExplorer 63ad09e
fix: adapt the unified-stack test suites to IndexedTopKPage
QuantumExplorer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.