chore(commitment-tree): bump orchard to dashified-0.14.1 - #768
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughUpdated the ChangesDependency Version Bump
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #768 +/- ##
========================================
Coverage 91.47% 91.47%
========================================
Files 240 240
Lines 67612 67612
========================================
Hits 61849 61849
Misses 5763 5763
🚀 New features to boost your workflow:
|
Updates the orchard git dependency from the dashified-0.14.0 tag (f055573) to the new dashified-0.14.1 tag (38ac9c19), a descendant of 0.14.0 that retains the circuit soundness fix. The five commits between the tags are non-breaking cleanups/perf on top of 0.14.0: - fix: make PCZT trial decryption generic over MemoSize - feat: enforce MemoSize invariants at compile time + DashMemo coverage - perf: build note plaintexts in a stack buffer instead of a heap Vec - cleanup: single source of truth for the AEAD tag size in the txid hasher - cleanup: extract compact ciphertext prefix in one place Pinned by tag (not rev) so the dependency reads as a named release. Crate version stays 0.14.0 internally. Verified: builds with client/server/sqlite features; the crate's 110 lib tests and grovedb's 50 commitment-tree integration tests all pass against this commit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
QuantumExplorer
force-pushed
the
chore/bump-orchard-latest-dashified
branch
from
July 6, 2026 18:08
0b225bf to
8cfa9f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the
orchardgit dependency ingrovedb-commitment-treefrom thedashified-0.14.0tag to the newdashified-0.14.1tag (38ac9c19a2df7bf3eeadc22ab23053e8fd538828).The
dashified-0.14.1tag was created on the head of dashpay/orchard'sdashifiedbranch so this bump can be pinned by a named release rather than a raw revision.Why it's safe
dashified-0.14.1(38ac9c19) is a descendant of thedashified-0.14.0tag commit (f055573), verified withgit merge-base --is-ancestor, so it retains the 0.14.0 circuit soundness fix that #758 migrated to — this moves forward, not sideways. The orchard crate version stays0.14.0internally (the tag name is just the dashified release marker). The five commits between the tags are non-breaking:fix:make PCZT trial decryption generic overMemoSizefeat:enforceMemoSizeinvariants at compile time +DashMemocoverageperf:build note plaintexts in a stack buffer instead of a heapVeccleanup:single source of truth for the AEAD tag size in the txid hashercleanup:extract the compact ciphertext prefix in one placeCargo.lockis gitignored in this repo, so thetaginCargo.tomlis the source of truth; it resolves to38ac9c19.Testing
cargo build -p grovedb-commitment-tree --features server,client,sqlite— clean against the tag.grovedbcommitment-tree integration tests: 50 passed, 0 failed.🤖 Generated with Claude Code
Summary by CodeRabbit