Skip to content

chore(commitment-tree): bump orchard to dashified-0.14.1 - #768

Merged
QuantumExplorer merged 1 commit into
developfrom
chore/bump-orchard-latest-dashified
Jul 6, 2026
Merged

chore(commitment-tree): bump orchard to dashified-0.14.1#768
QuantumExplorer merged 1 commit into
developfrom
chore/bump-orchard-latest-dashified

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Jul 6, 2026

Copy link
Copy Markdown
Member

What

Updates the orchard git dependency in grovedb-commitment-tree from the dashified-0.14.0 tag to the new dashified-0.14.1 tag (38ac9c19a2df7bf3eeadc22ab23053e8fd538828).

The dashified-0.14.1 tag was created on the head of dashpay/orchard's dashified branch so this bump can be pinned by a named release rather than a raw revision.

Why it's safe

dashified-0.14.1 (38ac9c19) is a descendant of the dashified-0.14.0 tag commit (f055573), verified with git merge-base --is-ancestor, so it retains the 0.14.0 circuit soundness fix that #758 migrated to — this moves forward, not sideways. The orchard crate version stays 0.14.0 internally (the tag name is just the dashified release marker). The five commits between the tags are non-breaking:

  • fix: make PCZT trial decryption generic over MemoSize
  • feat: enforce MemoSize invariants at compile time + DashMemo coverage
  • perf: build note plaintexts in a stack buffer instead of a heap Vec
  • cleanup: single source of truth for the AEAD tag size in the txid hasher
  • cleanup: extract the compact ciphertext prefix in one place

Cargo.lock is gitignored in this repo, so the tag in Cargo.toml is the source of truth; it resolves to 38ac9c19.

Testing

  • cargo build -p grovedb-commitment-tree --features server,client,sqlite — clean against the tag.
  • Commitment-tree crate suite (all features): 110 passed, 0 failed (2 ignored).
  • grovedb commitment-tree integration tests: 50 passed, 0 failed.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated a bundled dependency to a newer version for improved compatibility and maintenance.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Updated the orchard git dependency tag in grovedb-commitment-tree/Cargo.toml from dashified-0.14.0 to dashified-0.14.1, retaining the existing circuit feature flag.

Changes

Dependency Version Bump

Layer / File(s) Summary
Bump orchard dependency tag
grovedb-commitment-tree/Cargo.toml
Updates the orchard git dependency reference to tag dashified-0.14.1 from dashified-0.14.0, keeping the circuit feature.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • dashpay/grovedb#758: Also modifies the orchard git-tag pin in the same grovedb-commitment-tree/Cargo.toml file with the same feature configuration.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: bumping the orchard dependency to dashified-0.14.1.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-orchard-latest-dashified

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.47%. Comparing base (9b98a35) to head (8cfa9f6).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #768   +/-   ##
========================================
  Coverage    91.47%   91.47%           
========================================
  Files          240      240           
  Lines        67612    67612           
========================================
  Hits         61849    61849           
  Misses        5763     5763           
Components Coverage Δ
grovedb-core 89.07% <ø> (ø)
merk 92.26% <ø> (ø)
storage 86.20% <ø> (ø)
commitment-tree 96.05% <ø> (ø)
mmr 96.79% <ø> (ø)
bulk-append-tree 89.82% <ø> (ø)
element 97.38% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Updates the orchard git dependency from the dashified-0.14.0 tag (f055573)
to the new dashified-0.14.1 tag (38ac9c19), a descendant of 0.14.0 that
retains the circuit soundness fix. The five commits between the tags are
non-breaking cleanups/perf on top of 0.14.0:

  - fix: make PCZT trial decryption generic over MemoSize
  - feat: enforce MemoSize invariants at compile time + DashMemo coverage
  - perf: build note plaintexts in a stack buffer instead of a heap Vec
  - cleanup: single source of truth for the AEAD tag size in the txid hasher
  - cleanup: extract compact ciphertext prefix in one place

Pinned by tag (not rev) so the dependency reads as a named release. Crate
version stays 0.14.0 internally.

Verified: builds with client/server/sqlite features; the crate's 110 lib
tests and grovedb's 50 commitment-tree integration tests all pass against
this commit.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@QuantumExplorer
QuantumExplorer force-pushed the chore/bump-orchard-latest-dashified branch from 0b225bf to 8cfa9f6 Compare July 6, 2026 18:08
@QuantumExplorer QuantumExplorer changed the title chore(commitment-tree): bump orchard to latest dashified rev (38ac9c19) chore(commitment-tree): bump orchard to dashified-0.14.1 Jul 6, 2026
@QuantumExplorer
QuantumExplorer merged commit 8be8861 into develop Jul 6, 2026
11 checks passed
@QuantumExplorer
QuantumExplorer deleted the chore/bump-orchard-latest-dashified branch July 6, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant