Skip to content

fix: return error instead of silently discarding writes when storage batch is None (M3) - #604

Merged
QuantumExplorer merged 1 commit into
developfrom
fix/M3-silent-storage-data-loss
Mar 8, 2026
Merged

fix: return error instead of silently discarding writes when storage batch is None (M3)#604
QuantumExplorer merged 1 commit into
developfrom
fix/M3-silent-storage-data-loss

fix: return error instead of silently discarding writes when batch is…

a49a934
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 8, 2026 in 0s

90.69% (+0.06%) compared to ad90e2c

View this Pull Request on Codecov

90.69% (+0.06%) compared to ad90e2c

Details

Codecov Report

❌ Patch coverage is 98.01980% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.69%. Comparing base (ad90e2c) to head (a49a934).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../src/rocksdb_storage/storage_context/context_tx.rs 97.61% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #604      +/-   ##
===========================================
+ Coverage    90.63%   90.69%   +0.06%     
===========================================
  Files          182      182              
  Lines        49801    49966     +165     
===========================================
+ Hits         45136    45318     +182     
+ Misses        4665     4648      -17     
Components Coverage Δ
grovedb-core 88.78% <ø> (+0.03%) ⬆️
merk 92.06% <100.00%> (+0.11%) ⬆️
storage 86.37% <97.61%> (+0.87%) ⬆️
commitment-tree 96.41% <ø> (ø)
mmr 96.72% <ø> (ø)
bulk-append-tree 90.85% <ø> (ø)
element 97.55% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.