Skip to content

fix: include segments_count bytes in worst_case_body_size (M8) #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 1 commit into from
Mar 6, 2026
Merged

fix: include segments_count bytes in worst_case_body_size (M8) #565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion storage/src/rocksdb_storage/storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,11 @@ impl RocksDbStorage {
}

fn worst_case_body_size<L: WorstKeyLength>(path: &[L]) -> usize {
path.len() + path.iter().map(|a| a.max_length() as usize).sum::<usize>()
// body = segment_bytes + segments_count.to_ne_bytes() + lengths
// segments_count.to_ne_bytes() contributes size_of::<usize>() bytes
path.iter().map(|a| a.max_length() as usize).sum::<usize>()
+ std::mem::size_of::<usize>()
+ path.len()
}

/// Returns the write batch, with costs and pending costs
Expand Down
Loading