feat: transactions - #13
Merged
Merged
Conversation
# Conflicts: # grovedb/src/lib.rs # grovedb/src/subtree.rs # grovedb/src/tests.rs # merk/src/merk/mod.rs # storage/src/rocksdb_storage/mod.rs
antouhou
marked this pull request as ready for review
December 31, 2021 16:06
fominok
approved these changes
Jan 11, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic of
Merk::clearis not compatible with transactions really - something had to be redone.Merk::clear consumes itself. It also creates a batch. With transactions, the batch is either Batch or Transaction. But transaction borrows storage, and thus compiler thinks that storage lives less than the transaction.
All tests are passing, except the ones that delete subtrees. That’s because I’ve commented out
Merk::clearmethod as explained above.I’ve also left a pretty self-explanatory doc comment on
GroveDB::start_transaction. Runcargo doc --opento check it out. Please take a look at it! It is a bit ugly, but it works!Happy new year! 🥂