fix(dashpay): add back navigation to notifications - #991
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesNotifications navigation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
QuantumExplorer
approved these changes
Aug 11, 2026
QuantumExplorer
added a commit
that referenced
this pull request
Aug 28, 2026
) * feat(masternodes): unban a PoSe-banned masternode/evonode from the app An "Unban masternode" action on both masternode detail screens, riding the ProUpServTx orchestration that shipped in platform #4507 (rust-dashcore #991 underneath): the app broadcasts a provider update signed with the operator key, re-asserting the node's current service values, which revives it in the masternode list. - Wallet-owned nodes gate on operatorInWallet and sign through the mnemonic resolver at the record's resolved operator key index; tracked nodes gate on the shared canUpdateService capability and sign with the vaulted operator key text. Both fund the fee from the wallet's core funds. - The confirm sheet collects the evonode Platform P2P port (the masternode list doesn't carry it; defaults to the standard 26656) and — only when the SDK reports the node pays an operator reward — the operator payout address, which the payload replaces on-chain and must therefore never default. - Guided shielded top-up: with no spendable DASH for the fee, one tap withdraws 0.001 DASH from the shielded balance to the wallet's own address. The withdrawal settles through the network withdrawal queue minutes later, so the intent persists (PendingMasternodeUnbanStore, per wallet) and "Complete unban" resumes the flow — across app relaunches — once the funds land. - An unconfirmed broadcast is terminal (never retried), matching the send path's ambiguous-outcome discipline; the v3 extended-net-info refusal from the SDK gets its own explanatory copy. - Status copy for a list entry flagged invalid is now "PoSe banned" (it was "Inactive") — that is what the state means. Builds against swift-sdk at platform v4.2-dev 52e8d4ec68 or later. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(wallet): review — persist pending unban only after submission, guard duplicate submits, reject port 0, suppress the row post-broadcast - The pending-unban record now persists only once the shielded withdrawal was actually submitted (or its outcome is ambiguous) — an app killed during the authentication prompt no longer leaves a phantom "Complete unban" waiting for a payout that never comes. - submit() leaves .ready before suspending on authentication, so a second tap during the PIN prompt can't start a duplicate ProUpServTx. - Port 0 parses as a UInt16 but is not a usable service port — rejected. - After a successful broadcast both detail screens show "Unban submitted…" instead of re-offering the button while the DML entry is still banned for a few more blocks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The Notifications screen is pushed from Home inside a SwiftUI hosting controller whose UIKit navigation bar is hidden, leaving no visible way to return to Home.
What was done?
How Has This Been Tested?
Breaking Changes
None.
Checklist:
The dashpay scheme has no configured test target; this UI-only change was verified with a full build and navigation-flow audit.
Summary by CodeRabbit