Skip to content

fix(dashpay): remove duplicated contenderJoinDeadline after parallel merges - #967

Merged
QuantumExplorer merged 1 commit into
developfrom
fix/dedupe-contender-join-deadline
Aug 10, 2026
Merged

fix(dashpay): remove duplicated contenderJoinDeadline after parallel merges#967
QuantumExplorer merged 1 commit into
developfrom
fix/dedupe-contender-join-deadline

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

develop does not compile after the last two merges: #958's branch and #965 each added an identical contenderJoinDeadline(voteEnd:) to UsernameMarketplaceService, and the squash merges landed both — "invalid redeclaration of 'contenderJoinDeadline(voteEnd:)'".

What was done

Removed one of the two byte-identical copies. No behavior change.

How Has This Been Tested?

Clean dashpay arm64 simulator build on develop + this commit (develop alone fails). (Unit-test target pre-existing broken.)

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have added or updated relevant unit/integration/functional/e2e tests

🤖 Generated with Claude Code

…merges

develop stopped compiling: #958's branch and #965 each carried the
identical contenderJoinDeadline(voteEnd:) helper, and their squash
merges landed both copies in UsernameMarketplaceService ("invalid
redeclaration"). Keep one.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@QuantumExplorer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4a444f8f-771c-4718-a864-ab2b7b47e8a3

📥 Commits

Reviewing files that changed from the base of the PR and between 007785a and 4e44b9f.

📒 Files selected for processing (1)
  • DashWallet/Sources/Infrastructure/SwiftDashSDK/UsernameMarketplaceService.swift

Comment @coderabbitai help to get the list of available commands.

@QuantumExplorer
QuantumExplorer merged commit 3293f62 into develop Aug 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant