feat(ui): internal transfers render a circulating-arrows amount, not a sign

[QuantumExplorer]

Issue being fixed or feature implemented

An identity top-up row read "+2 Đ" — styled like an external receive — when the transaction only moved the wallet's own funds. Wallet-internal rows shouldn't claim a direction.

What was done

Every internal history row now renders its amount signless, with a circulating-arrows glyph (⟳) before it:

• main-feed rows with an internalTransferRoute: identity top-up / registration / invitation asset locks, to-Shielded transfers, Shielded → Transparent payouts, to-Platform fundings, and plain self-sends
• internal shielded-activity rows (already signless — now carry the glyph too)
• the CoinJoin "Mixing Transactions" group row

External sends and receives keep their +/- signs; Platform-address receives (external senders) are untouched.

The glyph is a new TransactionView.amountAccessorySystemImage in DashUIKit (dashpay/DashUIKit#10) — an optional SF Symbol before the trailing amount, secondary tone. dashpay/DashUIKit#10 has merged, and the package pin points at master (88bf41f), which carries both the new API and the fix/textfield-prompt-type compile fix iOS consumers need.

How Has This Been Tested?

Clean dashpay arm64 simulator build. Installed on the testnet QA simulator: the "Identity top-up" row shows "⟳ 2 Đ" (no sign), while an external "Sent to …" row keeps "-1 Đ". (Unit-test target pre-existing broken.)

Breaking Changes

None.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

🤖 Generated with Claude Code

Summary by CodeRabbit

• Style
  • Updated transaction rows with a circulating-arrows indicator for CoinJoin, internal transfers, and shielded activity.
  • Preserved directional signs for transactions that include transaction metadata.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fa2aed8c-bc04-4a83-bb3c-90969b18d595

📥 Commits

Reviewing files that changed from the base of the PR and between a9fddff and dde4713.

⛔ Files ignored due to path filters (1)

• DashWallet.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved

📒 Files selected for processing (1)

• DashWallet/Sources/UI/Home/Views/HomeView.swift

🚧 Files skipped from review as they are similar to previous changes (1)

• DashWallet/Sources/UI/Home/Views/HomeView.swift

---

📝 Walkthrough

Walkthrough

Home transaction rows now use circulating-arrows accessories for CoinJoin, internal transfers, and shielded activity. Internal-transfer detection applies only to metadata-less transactions. Other transactions retain directional signs.

Changes

Transaction amount accessories

Layer / File(s)	Summary
Home transaction row display DashWallet/Sources/UI/Home/Views/HomeView.swift	CoinJoin, internal transfer, and shielded activity rows display circulating-arrows accessories. Metadata-less internal transfers suppress directional signs. Other transactions retain existing sign formatting.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• dashpay/dashwallet-ios#939: Related transaction-history display logic covers internal-transfer and shielded-activity presentation.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main UI change for internal transfers.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/internal-transfer-amount-style

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@DashWallet/Sources/UI/Home/Views/HomeView.swift`:
- Around line 784-787: Update the amount presentation metadata in the HomeView
transaction configuration so the internal-transfer sign and route glyph are used
only when metadata == nil && txItem.internalTransferRoute != nil; otherwise
preserve the normal amount presentation. Add a regression test covering an
internal transfer with custom-icon metadata and verify the metadata takes
precedence for both amount fields.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bb3f78be-c06b-482b-917a-09a52bf370bd

📥 Commits

Reviewing files that changed from the base of the PR and between 369c517 and a9fddff.

⛔ Files ignored due to path filters (1)

• DashWallet.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved

📒 Files selected for processing (2)

• DashWallet.xcodeproj/project.pbxproj
• DashWallet/Sources/UI/Home/Views/HomeView.swift

[QuantumExplorer]

dashpay/DashUIKit#10 merged — the package pin is back on master (88bf41f, which includes both the amount-accessory API and the TextField-prompt compile fix). Clean dashpay arm64 simulator build on the new pin. The temporary-pin caveat in the PR description no longer applies.