Skip to content

refactor(home): drop the isReloading guard that could never fire #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 1 commit into from
Aug 7, 2026
Merged

refactor(home): drop the isReloading guard that could never fire #935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions DashWallet/Sources/UI/Home/Views/HomeViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ class HomeViewModel: ObservableObject {
var isPreviewMode: Bool = false
#endif

/// Tracks whether a full reload is currently in progress to prevent race conditions
/// with incremental updates (Fix #3)
private var isReloading: Bool = false

/// Tracks whether initial data load has completed (Fix #2)
private var hasCompletedInitialLoad: Bool = false

Expand Down Expand Up @@ -251,9 +247,8 @@ class HomeViewModel: ObservableObject {
self.crowdNodeTxSet = FullCrowdNodeSignUpTxSet()
self.coinJoinTxSets.removeAll()

// Reset load tracking flags so the new network's data loads correctly
// Reset load tracking so the new network's data loads correctly
self.hasCompletedInitialLoad = false
self.isReloading = false

// Update UI-bound properties on main thread. The new network's
// history is loading from scratch, so the feed goes back to its
Expand Down Expand Up @@ -441,8 +436,6 @@ class HomeViewModel: ObservableObject {
}

private func performReload(selectedFilters: Set<TransactionFilterCategory>, startedAt: Date) {
// Fix #3: Set reload flag to prevent race conditions with incremental updates
self.isReloading = true
DWLogger.log("HomeViewModel: Starting full transaction reload")

let transactions = transactionSource.allTransactions
Expand Down Expand Up @@ -565,9 +558,8 @@ class HomeViewModel: ObservableObject {
return TransactionGroup(id: key, date: first.date, items: items)
}.sorted { $0.date > $1.date }

// Fix #2 & #3: Mark initial load complete and clear reload flag
// Fix #2: Mark initial load complete
self.hasCompletedInitialLoad = true
self.isReloading = false

let elapsedMs = Int(Date().timeIntervalSince(startedAt) * 1000)
DWLogger.log("HomeViewModel: Full reload complete in \(elapsedMs)ms, \(array.count) groups, \(self.txByHash.count) transactions cached")
Expand All @@ -588,13 +580,6 @@ class HomeViewModel: ObservableObject {
self.queue.async { [weak self] in
guard let self = self else { return }

// Fix #3: Skip incremental updates while a full reload is in progress
// to prevent race conditions that could cause missing transactions
if self.isReloading {
DWLogger.log("HomeViewModel: Skipping incremental update during full reload for tx: \(tx.txHashHexString)")
return
}

// Fix #2: If initial load hasn't completed yet, the cache is empty and
// incremental updates won't work correctly. Trigger a full reload instead.
if !self.hasCompletedInitialLoad {
Expand Down
Loading