changes for rearchitecture - #13
Merged
podkovyrin merged 1 commit intoNov 26, 2018
Merged
Conversation
llbartekll
added a commit
that referenced
this pull request
Apr 13, 2026
Merges three commits from the migration-235 worktree: - feat: mirror PIN-change re-encryption into SwiftDashSDK (#10) - feat: migrate backup seed phrase display to SwiftDashSDK (#13) - feat: flip mnemonic generation to SwiftDashSDK (#3) Resolved UUID collisions in pbxproj (remapped 109-114 → 115-121 to avoid overlap with Container/WalletState UUIDs from HEAD). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
llbartekll
added a commit
that referenced
this pull request
May 14, 2026
SwiftDashSDK's WalletStorage no longer keeps a PIN-encrypted seed (mnemonics are stored as plain keychain bytes via storeMnemonic; legacy wallet.seed / wallet.pin accounts are scrubbed on launch by cleanupLegacyItems), so the PIN-change mirror is no longer required — the adapter's body had already been reduced to a logger-only no-op. Delete SwiftDashSDKPinChanger.swift and its six Xcode project references, collapse DWSetPinModel.setPin: to a thin wrapper around [DSAuthenticationManager setupNewPin:], and update DASHSYNC_MIGRATION.md rows #10 and #13 to reflect that PIN handling remains entirely a DashSync concern. No DashSync code paths modified; both dashwallet and dashpay schemes build clean on iPhone 17 simulator. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
llbartekll
added a commit
that referenced
this pull request
May 14, 2026
Two more thin @objc → Swift bridges (both Stage-2-Solo-shaped: only SwiftDashSDK calls, no DashSync) collapsed onto their single Obj-C consumer. Same template as the prior validator and address-validator retirements (commits 4f17829 and c5f6787) — but bundled here because both share one consumer file. - Delete `SwiftDashSDKMnemonicGenerator.swift` (41-line `@objc` adapter calling `Mnemonic.generate(wordCount:)`). - Delete `SwiftDashSDKMnemonicReader.swift` (36-line `@objc` adapter walking `WalletStorage().listWalletIdsWithMnemonic()` + `retrieveMnemonic(for:)`). - Add `DWPreviewSeedPhraseModel+Mnemonic.swift` — Swift extension on the consumer model exposing both `@objc(generateAndStoreMnemonic)` and `@objc(readStoredMnemonic)` as instance methods. Behavior is byte-identical; the OS log category collapses to one (`swift-sdk-migration.preview-seed-phrase-model`). - Swap two call sites in `DWPreviewSeedPhraseModel.m` to call `[self ...]` (the file already imports `dashwallet-Swift.h`). - Swap the file references in the Xcode project (12 entries removed for the two adapters, 6 added for the new extension; group entry moves from the SwiftDashSDK group to SecureWallet/Seed). - Update `DASHSYNC_MIGRATION.md` rows #3 and #13 to reference the new extension instead of the deleted adapters. Stages stay 🌗 Flipped — the DashSync write-side mirrors aren't affected by this change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
llbartekll
added a commit
that referenced
this pull request
Jun 18, 2026
CoinJoin row #20 corrected: mixing is being dropped (legacy mixing UI already retired), not migrated. The one capability that moves over — recovering/sweeping already-mixed coins into spendable balance — is implemented on both sides via ManagedCoreWallet.sweepCoinJoinAccount (platform PR #3817, awaiting merge). CoinJoin is no longer the 'keep DashSync linked indefinitely' hard blocker. Updated the functional table, 'Where we are', Hard blockers, and Wave 6. Easy-win status promotions: - #13 Backup seed phrase: Flipped -> Done (backup read is 100% SwiftDashSDK, no fallback; adapter already retired). - #19 DPNS username lookup: Flipped -> Done (availability check fully on SDK; prefix search carved out to #18; dead request residue removed). - #10 PIN-change half: close-out note (mirror retired permanently, stays on DashSync by decision). - #7: isMinimal noted as removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.