Skip to content

feat: add evo quorum platformsign command #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lklimek merged 3 commits into from
Jul 23, 2024
Merged

feat: add evo quorum platformsign command #23

lklimek merged 3 commits into from
Jul 23, 2024

Conversation

@lklimek
Copy link

@lklimek lklimek commented Jul 22, 2024

For a more granular access control, Core introduced new endpoint quorum platformsign dedicated to Dash Platform.

This PR adds that endpoint to REST interface.

@lklimek lklimek mentioned this pull request Jul 22, 2024
Merged
5 tasks
@coveralls
Copy link

coveralls commented Jul 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10040359601

Details

  • 27 of 37 (72.97%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 54.089%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcjson/dashevocmds.go 17 19 89.47%
rpcclient/evo.go 8 16 50.0%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 2 86.79%
Totals Coverage Status
Change from base Build 5553939634: 0.2%
Covered Lines: 24578
Relevant Lines: 45440
💛 - Coveralls

2 similar comments
@coveralls
Copy link

coveralls commented Jul 22, 2024

Pull Request Test Coverage Report for Build 10040359601

Details

  • 27 of 37 (72.97%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 54.089%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcjson/dashevocmds.go 17 19 89.47%
rpcclient/evo.go 8 16 50.0%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 2 86.79%
Totals Coverage Status
Change from base Build 5553939634: 0.2%
Covered Lines: 24578
Relevant Lines: 45440
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10040359601

Details

  • 27 of 37 (72.97%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 54.089%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcjson/dashevocmds.go 17 19 89.47%
rpcclient/evo.go 8 16 50.0%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 2 86.79%
Totals Coverage Status
Change from base Build 5553939634: 0.2%
Covered Lines: 24578
Relevant Lines: 45440
💛 - Coveralls

shumkov
shumkov approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit ae5027b into master Jul 23, 2024
@lklimek lklimek deleted the feat/platform-quorum-sign branch July 23, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shumkov shumkov shumkov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lklimek @coveralls @shumkov