refactor: drop dependency on net_processing for multiple consensus related objects

src/Makefile.am

@@ -287,7 +287,6 @@ BITCOIN_CORE_H = \
   masternode/node.h \
   masternode/meta.h \
   masternode/payments.h \
-  masternode/sync.h \
   masternode/utils.h \
   memusage.h \
   merkleblock.h \
@@ -296,6 +295,9 @@ BITCOIN_CORE_H = \
   net.h \
   net_permissions.h \
   net_processing.h \
+  net_governance.h \
+  net_instantsend.h \
+  net_signing.h \
   net_types.h \
   netaddress.h \
   netbase.h \
@@ -313,6 +315,7 @@ BITCOIN_CORE_H = \
   node/miner.h \
   node/minisketchwrapper.h \
   node/psbt.h \
+  node/sync.h \
   node/transaction.h \
   node/txreconciliation.h \
   node/interface_ui.h \
@@ -551,12 +554,14 @@ libbitcoin_node_a_SOURCES = \
   masternode/node.cpp \
   masternode/meta.cpp \
   masternode/payments.cpp \
-  masternode/sync.cpp \
   masternode/utils.cpp \
   net.cpp \
   netfulfilledman.cpp \
   netgroup.cpp \
   net_processing.cpp \
+  net_governance.cpp \
+  net_instantsend.cpp \
+  net_signing.cpp \
   node/blockstorage.cpp \
   node/caches.cpp \
   node/chainstate.cpp \
@@ -569,6 +574,7 @@ libbitcoin_node_a_SOURCES = \
   node/miner.cpp \
   node/minisketchwrapper.cpp \
   node/psbt.cpp \
+  node/sync.cpp \
   node/transaction.cpp \
   node/txreconciliation.cpp \
   node/interface_ui.cpp \

src/chainlock/chainlock.cpp

@@ -18,7 +18,7 @@
 
 #include <instantsend/instantsend.h>
 #include <llmq/quorums.h>
-#include <masternode/sync.h>
+#include <node/sync.h>
 #include <spork.h>
 #include <stats/client.h>
 

src/chainlock/signing.cpp

@@ -10,7 +10,7 @@
 #include <chainlock/clsig.h>
 #include <instantsend/instantsend.h>
 #include <llmq/signing_shares.h>
-#include <masternode/sync.h>
+#include <node/sync.h>
 #include <spork.h>
 
 using node::ReadBlockFromDisk;
@@ -141,7 +141,7 @@ void ChainLockSigner::TrySignChainTip(const llmq::CInstantSendManager& isman)
         lastSignedMsgHash = msgHash;
     }
 
-    m_shareman.AsyncSignIfMember(Params().GetConsensus().llmqTypeChainLocks, m_sigman, requestId, msgHash);
+    m_shareman.AsyncSignIfMember(Params().GetConsensus().llmqTypeChainLocks, requestId, msgHash);
 }
 
 void ChainLockSigner::EraseFromBlockHashTxidMap(const uint256& hash)

src/coinjoin/client.cpp

@@ -10,7 +10,7 @@
 #include <core_io.h>
 #include <evo/deterministicmns.h>
 #include <masternode/meta.h>
-#include <masternode/sync.h>
+#include <node/sync.h>
 #include <net.h>
 #include <netmessagemaker.h>
 #include <rpc/evo_util.h>

src/coinjoin/coinjoin.cpp

@@ -16,7 +16,7 @@
 #include <bls/bls.h>
 #include <chainlock/chainlock.h>
 #include <instantsend/instantsend.h>
-#include <masternode/sync.h>
+#include <node/sync.h>
 
 #include <string>
 

src/coinjoin/server.cpp

@@ -8,7 +8,7 @@
 #include <evo/deterministicmns.h>
 #include <masternode/meta.h>
 #include <masternode/node.h>
-#include <masternode/sync.h>
+#include <node/sync.h>
 #include <net.h>
 #include <netmessagemaker.h>
 #include <net_processing.h>

src/dsnotificationinterface.cpp

@@ -18,7 +18,7 @@
 #include <llmq/dkgsessionmgr.h>
 #include <llmq/ehf_signals.h>
 #include <llmq/quorums.h>
-#include <masternode/sync.h>
+#include <node/sync.h>
 
 CDSNotificationInterface::CDSNotificationInterface(CConnman& connman,
                                                    CDSTXManager& dstxman,

src/evo/mnauth.cpp

@@ -10,7 +10,7 @@
 #include <llmq/utils.h>
 #include <masternode/meta.h>
 #include <masternode/node.h>
-#include <masternode/sync.h>
+#include <node/sync.h>
 #include <net.h>
 #include <netmessagemaker.h>
 #include <util/time.h>