[v23.0.x] chore: add release notes #6932
Conversation
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR consolidates release notes for Dash Core v23.0.0 by removing 38 individual PR-specific release note files and updating doc/release-notes.md to comprehensively document the v23 release. The consolidation follows the standard Dash Core release workflow where individual per-PR note fragments created during development are merged into a unified document for the final release. Key changes documented include mandatory EvoDB migration, breaking changes to block filter indexes, extended masternode address support, numerous RPC deprecations/updates, wallet improvements, and GUI enhancements. The file also adds complete release notes for the v22.1.3 minor release.
PR Description Notes:
- The PR description is incomplete with empty sections for "What was done?", "How Has This Been Tested?", and "Breaking Changes" which should be filled in for proper documentation
Important Files Changed
| Filename | Score | Overview |
|---|---|---|
| doc/release-notes.md | 4/5 | Comprehensive update from v22.1.3 to v23.0.0 release notes; credits section empty and comparison URL needs verification post-tagging |
| doc/release-notes/dash/release-notes-22.1.3.md | 4/5 | New file documenting v22.1.3 release; contains potential date inconsistency in "Older releases" section (future dates listed) |
| doc/release-notes-6567.md | 5/5 | Deleted file documenting removed deprecated RPCs; consolidated into main release notes |
| doc/release-notes-6711.md | 5/5 | Deleted file about BIP157 auto-enablement for masternodes; consolidated into main release notes |
| doc/release-notes-6811.md | 5/5 | Deleted file about deprecated platform port keys; consolidated into main release notes |
| doc/release-notes-24098.md | 5/5 | Deleted file about REST API endpoint changes; consolidated into main release notes |
| doc/release-notes-25158.md | 5/5 | Deleted file about RPC wallet enhancements; consolidated into main release notes |
| doc/release-notes-6835.md | 5/5 | Deleted file about mobile CoinJoin compatibility; consolidated into main release notes |
| doc/release-notes-6634.md | 5/5 | Deleted file about port validation and UNIX socket support; consolidated into main release notes |
| doc/release-notes-6813.md | 5/5 | Deleted file about EvoDB migration; consolidated into main release notes |
| doc/release-notes-6665.md | 5/5 | Deleted file about masternode address RPC changes; consolidated into main release notes |
| doc/release-notes-22918.md | 5/5 | Deleted file about getblock verbosity level 3; consolidated into main release notes |
| doc/release-notes-6594.md | 5/5 | Deleted file about CoinJoin RPC changes; consolidated into main release notes |
| doc/release-notes-6723.md | 5/5 | Deleted file about deprecated legacy masternode RPCs; consolidated into main release notes |
| doc/release-notes-6685.md | 5/5 | Deleted file about randomized change output amounts; consolidated into main release notes |
| doc/release-notes-6686.md | 5/5 | Deleted file about removed instantsendtoaddress RPC; consolidated into main release notes |
| doc/release-notes-14707.md | 4/5 | Deleted file about receivedby RPC coinbase handling; consolidated into main release notes |
| doc/release-notes-6628.md | 5/5 | Deleted file about quorum rotationinfo parameter change; consolidated into main release notes |
| doc/release-notes-23093.md | 5/5 | Deleted file about newkeypool RPC; consolidated into main release notes |
| doc/release-notes-6579.md | 5/5 | Deleted file about EvoDB migration removal; consolidated into main release notes |
| doc/release-notes-6482.md | 5/5 | Deleted file about -platform-user removal; consolidated into main release notes |
| doc/release-notes-6649.md | 5/5 | Deleted file about -maxconnections=0 behavior; consolidated into main release notes |
| doc/release-notes-6877.md | 5/5 | Deleted file about MIN_PEER_PROTO_VERSION bump; consolidated into main release notes |
| doc/release-notes-6505.md | 5/5 | Deleted file about statistics argument removal; consolidated into main release notes |
| doc/release-notes-27068.md | 4/5 | Deleted file about wallet passphrase null character support; consolidated into main release notes |
| doc/release-notes-6729.md | 5/5 | Deleted file about legacy masternode restrictions; consolidated into main release notes |
| doc/release-notes-6690.md | 5/5 | Deleted file about GUI governance voting; consolidated into main release notes |
| doc/release-notes-24629.md | 5/5 | Deleted file about pruneblockchain off-by-one fix; consolidated into main release notes |
| doc/release-notes-6607.md | 5/5 | Deleted file about getislocks request id field; consolidated into main release notes |
| doc/release-notes-6608.md | 5/5 | Deleted file about isdlock cycleHash field change; consolidated into main release notes |
| doc/release-notes-6648.md | 5/5 | Deleted file about GUI wallet restore feature; consolidated into main release notes |
| doc/release-notes-22650.md | 5/5 | Deleted file about -deprecatedrpc=addresses removal; consolidated into main release notes |
| doc/release-notes-6666.md | 3/5 | Deleted 65-line file documenting extended addresses feature; needs verification that content preserved elsewhere |
| doc/release-notes-6837.md | 5/5 | Deleted file about StatsD client improvements; consolidated into main release notes |
| doc/release-notes/release-notes-24408.md | 5/5 | Deleted file about gettxspendingprevout RPC; consolidated into main release notes |
| doc/release-notes-6825.md | 5/5 | Deleted file about breaking block filter index format update; consolidated into main release notes |
| doc/release-notes-26618.md | 3/5 | Deleted file about unloadwallet rescan behavior; needs verification of content preservation |
| doc/release-notes-6389.md | 4/5 | Deleted file about compiler requirement changes; critical build info must be in consolidated notes |
| doc/release-notes-6720.md | 5/5 | Deleted file about protx RPC submit parameter; consolidated into main release notes |
Confidence score: 3/5
- This PR consolidates release documentation but has several concerns that should be addressed before merging
- Score reduced due to: (1) empty credits section in main release notes requiring population, (2) incomplete PR description missing key information about what was done and testing approach, (3) three specific files (6666.md, 26618.md, 6389.md) requiring verification that critical content was properly preserved in consolidated notes, and (4) potential date inconsistencies in the v22.1.3 release notes file
- Pay close attention to doc/release-notes.md (lines 253-255credits section, line 321 comparison URL), doc/release-notes/dash/release-notes-22.1.3.md (lines 68-70 future dates), and verify that significant content from doc/release-notes-6666.md (extended addresses), doc/release-notes-26618.md (unloadwallet behavior), and doc/release-notes-6389.md (compiler requirements) is preserved in the consolidated notes
Context used:
- Context from
dashboard- CLAUDE.md (source)
39 files reviewed, 1 comment
|
|
||
| These releases are considered obsolete. Old release notes can be found here: | ||
|
|
||
| - [v22.1.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-22.1.2.md) released Apr/15/2025 |
There was a problem hiding this comment.
logic: The date for v22.1.2 release (Apr/15/2025) is in the future relative to the current date (October 29, 2025). This appears to be an error. Is the release date for v22.1.2 actually April 15, 2024 instead of 2025?
Prompt To Fix With AI
This is a comment left during a code review.
Path: doc/release-notes/dash/release-notes-22.1.3.md
Line: 68:68
Comment:
**logic:** The date for v22.1.2 release (Apr/15/2025) is in the future relative to the current date (October 29, 2025). This appears to be an error. Is the release date for v22.1.2 actually April 15, 2024 instead of 2025?
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
You're absolutely right to question this! Looking at the file, the date April 15, 2025 for v22.1.2 is indeed problematic, but actually the issue is even worse - we're currently on October 29, 2025, so that date is actually in the past now, not the future. My original comment was incorrect because I was comparing it to October 29, 2025.
However, the real issue is that April 15, 2025 is likely still wrong. Looking at the pattern of other releases:
- v22.1.1 was released Feb/17/2025
- v22.1.0 was released Feb/10/2025
- v22.0.0 was released Dec/12/2024
Given this timeline, v22.1.2 should have been released sometime between February 2025 and when v22.1.3 is being released. The date April 15, 2025 could be correct if v22.1.2 was actually released then, but it seems more likely this should be April 15, 2024 to fit the chronological pattern with earlier releases.
Can you confirm what the actual release date for v22.1.2 was?
There was a problem hiding this comment.
@coderabbitai does the comment above about dates make sense?
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check the v22.1.2 release notes file for the actual release date
if [ -f "doc/release-notes/dash/release-notes-22.1.2.md" ]; then
echo "=== Contents of v22.1.2 release notes ==="
cat doc/release-notes/dash/release-notes-22.1.2.md
else
echo "v22.1.2 release notes file not found"
fi
echo ""
echo "=== Checking git tags for v22.1.2 ==="
git tag -l "*22.1.2*" --format='%(refname:short) - %(creatordate:short)'
echo ""
echo "=== Checking GitHub releases (if available) ==="
gh release view v22.1.2 --json tagName,publishedAt,createdAt 2>/dev/null || echo "Could not fetch release info via gh CLI"
Length of output: 10126
@thephez No, the greptile-apps bot's comment doesn't make sense. Here's why:
The date April 15, 2025 for v22.1.2 is correct and fits the chronological pattern perfectly.
Looking at the actual timeline:
- v22.0.0: December 12, 2024
- v22.1.0: February 10, 2025
- v22.1.1: February 17, 2025
- v22.1.2: April 15, 2025 ← This is correct
- Current date: October 29, 2025
The bot made several errors:
-
Initial error: It claimed April 15, 2025 is "in the future" relative to October 29, 2025 — this is simply wrong (April comes before October in the same year)
-
Second error: While it corrected itself about past vs. future, it then suggested changing the year to 2024, which would place v22.1.2 before v22.0.0 (December 2024). This breaks the logical chronological order.
-
Logic flaw: The bot's suggested date of April 15, 2024 would mean releasing v22.1.2 eight months before v22.0.0, which makes no sense.
The existing date April 15, 2025 is correct — it's about 2 months after v22.1.1 and about 6 months before the current date, which is a reasonable release cadence.
There was a problem hiding this comment.
I've never had this much fun reviewing release notes!
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
doc/release-notes.md
Outdated
| * Dash Core will no longer permit the registration of new legacy scheme masternodes after the deployment of the v24 | ||
| fork. Existing basic scheme masternodes will also be prohibited from downgrading to the legacy scheme after the | ||
| deployment is active. (#6729) |
There was a problem hiding this comment.
Is the v24 reference correct? If so, does it belong in these release notes?
There was a problem hiding this comment.
Fair; let's probably drop this for now
doc/release-notes.md
Outdated
| Downgrading to a version older than v23.0.0 may not be supported, and will | ||
| likely require a reindex. | ||
|
|
||
| # Release Notes | ||
| # Notable changes | ||
|
|
||
| Bug Fixes | ||
| ---------- | ||
| EvoDB migration | ||
| --------------- | ||
|
|
||
| This release introduces a new internal format for masternode state data to support extended addresses and make future updates of this data seamless. Nodes will automatically migrate to the new format. Downgrading to an earlier version would require a full reindex. #6813 |
There was a problem hiding this comment.
Downgrading to a version older than v23.0.0 may not be supported, and will
likely require a reindex.
Downgrading to an earlier version would require a full reindex. #6813
should it be a bit more definitive in the first section?
|
|
||
|
|
There was a problem hiding this comment.
nit: is it bug with an empty lines at the end?
doc/release-notes.md
Outdated
| - PastaPastaPasta | ||
| - | ||
| - | ||
| - |
There was a problem hiding this comment.
Need to add contributors, I guess?
thephez
left a comment
thephez
left a comment
There was a problem hiding this comment.
@PastaPastaPasta I left my comments individually to try to avoid creating duplicate comments if other reviewers were looking at this simultaneously.
| * The deprecated key is still available without additional runtime arguments, but is liable to be removed in future versions | ||
| of Dash Core. (#6811) | ||
|
|
||
| * `protx revoke` will now use the legacy scheme version for legacy masternodes instead of defaulting to the |
There was a problem hiding this comment.
protx's related changes are very massive
I would suggest to group all protx / address related changes together, or at least post them close to each other (now they are separated by instantsentoaddress and bls generate
doc/release-notes.md
Outdated
| They can be re-enabled with the runtime argument `-deprecatedrpc=legacy_mn`. | ||
|
|
||
| * The argument `legacy` in `bls generate` has been deprecated in Dash Core v23 and may be ignored in a future version. | ||
| It can be re-enabled with the runtime argument `deprecatedrpc=legacy_mn`. (#6723) |
There was a problem hiding this comment.
| It can be re-enabled with the runtime argument `deprecatedrpc=legacy_mn`. (#6723) | |
| It can be re-enabled with the runtime argument `-deprecatedrpc=legacy_mn`. (#6723) |
|
Applied changes |
doc/release-notes.md
Outdated
| - The `/headers/` and `/blockfilterheaders/` endpoints have been updated to use | ||
| a query parameter instead of a path parameter to specify the result count. The | ||
| count parameter is now optional and defaults to 5 for both endpoints. The old | ||
| endpoints are still functional, and have no documented behaviour change. (#24098) |
There was a problem hiding this comment.
nit: here and in a couple more places - should maybe reference the PR that backported this, not the original one
Replace Bitcoin Core PR numbers (>7000) with their corresponding Dash Core backport PR numbers in release notes: - bitcoin#24098 -> dashpay#6784 (REST API endpoints) - bitcoin#22650 -> dashpay#6569 (deprecatedrpc=addresses removal) - bitcoin#22918 -> dashpay#6577 (getblock verbosity level 3) - bitcoin#23093 -> dashpay#6577 (newkeypool RPC) - bitcoin#24629 -> dashpay#6784 (pruneblockchain fix) - bitcoin#25158 -> dashpay#6780 (abandoned field in wallet RPCs)
|
Changes made |
|
Consider adding to release notes this fix https://github.com/dashpay/dash/pull/6938/files |
4 participants
Issue being fixed or feature implemented
Add release notes for v23
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.