backport: bitcoin/bitcoin#25645, #25668 fix iwyu on node/chainstate, dbwrapper.h and related fixes

ci/dash/lint-tidy.sh

@@ -21,10 +21,17 @@ fi
 cd "${BASE_ROOT_DIR}/build-ci/dashcore-${BUILD_TARGET}"
 iwyu_tool.py \
   "src/compat" \
+  "src/dbwrapper.cpp" \
   "src/init" \
+  "src/node/chainstate.cpp" \
+  "src/policy/feerate.cpp" \
+  "src/policy/packages.cpp" \
+  "src/policy/settings.cpp" \
+  "src/primitives/transaction.cpp" \
   "src/rpc/fees.cpp" \
   "src/rpc/signmessage.cpp" \
   "src/test/fuzz/txorphan.cpp" \
+  "src/threadinterrupt.cpp" \
   "src/util/bip32.cpp" \
   "src/util/bytevectorhash.cpp" \
   "src/util/check.cpp" \

src/bench/checkblock.cpp

@@ -9,6 +9,7 @@
 #include <consensus/validation.h>
 #include <stats/client.h>
 #include <streams.h>
+#include <util/system.h>
 #include <validation.h>
 
 #include <memory>

src/dbwrapper.cpp

@@ -4,15 +4,26 @@
 
 #include <dbwrapper.h>
 
-#include <memory>
+#include <fs.h>
+#include <logging.h>
 #include <random.h>
+#include <util/strencodings.h>
+#include <util/system.h>
 
+#include <algorithm>
+#include <cassert>
+#include <cstdarg>
+#include <cstdint>
+#include <cstdio>
 #include <leveldb/cache.h>
+#include <leveldb/db.h>
 #include <leveldb/env.h>
 #include <leveldb/filter_policy.h>
 #include <leveldb/helpers/memenv/memenv.h>
-#include <stdint.h>
-#include <algorithm>
+#include <leveldb/iterator.h>
+#include <leveldb/options.h>
+#include <leveldb/status.h>
+#include <memory>
 #include <optional>
 
 class CBitcoinLevelDBLogger : public leveldb::Logger {

src/dbwrapper.h

@@ -5,18 +5,38 @@
 #ifndef BITCOIN_DBWRAPPER_H
 #define BITCOIN_DBWRAPPER_H
 
+#include <assert.h>
 #include <clientversion.h>
 #include <fs.h>
+#include <logging.h>
 #include <serialize.h>
 #include <span.h>
 #include <streams.h>
-#include <util/strencodings.h>
-#include <util/system.h>
 
-#include <typeindex>
+#include <sys/types.h>
 
+#include <algorithm>
+#include <cstddef>
+#include <cstdint>
+#include <exception>
 #include <leveldb/db.h>
+#include <leveldb/iterator.h>
+#include <leveldb/options.h>
+#include <leveldb/slice.h>
+#include <leveldb/status.h>
 #include <leveldb/write_batch.h>
+#include <map>
+#include <memory>
+#include <set>
+#include <stdexcept>
+#include <string>
+#include <type_traits>
+#include <utility>
+#include <vector>
+
+namespace leveldb {
+class Env;
+}
 
 static const size_t DBWRAPPER_PREALLOC_KEY_SIZE = 64;
 static const size_t DBWRAPPER_PREALLOC_VALUE_SIZE = 1024;

src/evo/evodb.cpp

@@ -3,6 +3,7 @@
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
 #include <evo/evodb.h>
+#include <util/system.h>
 
 #include <uint256.h>
 

src/evo/specialtxman.cpp

@@ -11,6 +11,7 @@
 #include <hash.h>
 #include <primitives/block.h>
 #include <util/irange.h>
+#include <util/system.h>
 #include <validation.h>
 
 #include <chainlock/chainlock.h>

src/index/base.cpp

@@ -8,6 +8,7 @@
 #include <node/interface_ui.h>
 #include <shutdown.h>
 #include <tinyformat.h>
+#include <util/system.h>
 #include <util/thread.h>
 #include <util/translation.h>
 #include <validation.h>

src/index/blockfilterindex.cpp

@@ -9,6 +9,7 @@
 #include <index/blockfilterindex.h>
 #include <node/blockstorage.h>
 #include <serialize.h>
+#include <util/system.h>
 
 using node::UndoReadFromDisk;
 

src/index/coinstatsindex.cpp

@@ -10,6 +10,7 @@
 #include <serialize.h>
 #include <txdb.h>
 #include <undo.h>
+#include <util/system.h>
 #include <validation.h>
 #include <util/check.h>
 

src/init/common.cpp

@@ -16,6 +16,7 @@
 #include <node/interface_ui.h>
 #include <random.h>
 #include <tinyformat.h>
+#include <util/time.h>
 #include <util/string.h>
 #include <util/system.h>
 #include <util/translation.h>

src/node/chainstate.cpp

@@ -4,19 +4,35 @@
 
 #include <node/chainstate.h>
 
+#include <chain.h>
+#include <coins.h>
 #include <chainparamsbase.h>
 #include <consensus/params.h>
 #include <deploymentstatus.h>
 #include <node/blockstorage.h>
+#include <sync.h>
+#include <threadsafety.h>
+#include <tinyformat.h>
+#include <txdb.h>
+#include <txmempool.h>
+#include <uint256.h>
+#include <util/translation.h>
 #include <validation.h>
 
+#include <bls/bls.h>
 #include <evo/chainhelper.h>
 #include <evo/creditpool.h>
 #include <evo/deterministicmns.h>
 #include <evo/evodb.h>
 #include <evo/mnhftx.h>
+#include <gsl/pointers.h>
 #include <llmq/context.h>
 
+#include <atomic>
+#include <cassert>
+#include <memory>
+#include <vector>
+
 namespace node {
 std::optional<ChainstateLoadingError> LoadChainstate(bool fReset,
                                                      ChainstateManager& chainman,

src/policy/packages.h

@@ -5,7 +5,6 @@
 #ifndef BITCOIN_POLICY_PACKAGES_H
 #define BITCOIN_POLICY_PACKAGES_H
 
-#include <consensus/consensus.h>
 #include <consensus/validation.h>
 #include <policy/policy.h>
 #include <primitives/transaction.h>

src/primitives/transaction.h

@@ -12,13 +12,12 @@
 #include <serialize.h>
 #include <uint256.h>
 
-#include <cstddef>
+#include <algorithm>
 #include <cstdint>
-#include <ios>
+#include <iterator>
 #include <limits>
 #include <memory>
 #include <string>
-#include <tuple>
 #include <utility>
 #include <vector>
 

src/qt/optionsdialog.cpp

@@ -23,11 +23,12 @@
 #include <netbase.h>
 #include <txdb.h> // for -dbcache defaults
 #include <util/strencodings.h>
+#include <util/system.h>
 #include <util/underlying.h>
 
-#include <QButtonGroup>
 #include <chrono>
 
+#include <QButtonGroup>
 #include <QDataWidgetMapper>
 #include <QDir>
 #include <QIntValidator>

src/rpc/mempool.cpp

@@ -16,6 +16,8 @@
 #include <univalue.h>
 #include <util/moneystr.h>
 #include <validation.h>
+#include <util/system.h>
+#include <util/time.h>
 
 #include <instantsend/instantsend.h>
 #include <llmq/context.h>

src/txdb.h

@@ -9,6 +9,7 @@
 #include <coins.h>
 #include <dbwrapper.h>
 #include <spentindex.h>
+#include <sync.h>
 #include <timestampindex.h>
 
 #include <memory>

src/util/bip32.cpp

@@ -6,7 +6,6 @@
 #include <util/bip32.h>
 #include <util/strencodings.h>
 
-#include <algorithm>
 #include <cstdint>
 #include <cstdio>
 #include <sstream>

src/util/check.cpp

@@ -13,7 +13,6 @@
 
 #include <cstdio>
 #include <cstdlib>
-#include <string>
 
 
 NonFatalCheckError::NonFatalCheckError(const char* msg, const char* file, int line, const char* func)