depends: update 'src/dashbls' to dashpay/bls-signatures@dd683653 as e686744e

[kwvg]

Additional Information

• Dependency for backport: bitcoin/bitcoin#28461: build: Windows SSP roundup #6889
• Expected subtree hash bcd9c069752f3bf10e3812200ad990671dae230a34c2c0aa92e4c15032613743 (see instructions to calculate)

Breaking Changes

None expected.

Checklist:

• I have performed a self-review of my own code (note: N/A)
• I have commented my code, particularly in hard-to-understand areas (note: N/A)
• I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
• I have made corresponding changes to the documentation (note: N/A)
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[github-actions]

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

• backport: bitcoin/bitcoin#28461: build: Windows SSP roundup #6889 - Merge bitcoin/bitcoin#28461: build: Windows SSP roundup

Please coordinate with the authors of these PRs to avoid merge conflicts.

[coderabbitai]

Walkthrough

• CI: GitHub Actions workflow switches OS matrix entry from ubuntu-20.04 to ubuntu-latest.
• Build/config: libdashbls package version updated from 1.3.5 to 1.3.6 in configure.ac.
• Hardening: Removed MinGW-specific libssp presence check from configure.ac.
• CMake: Increased minimum required version to 3.14 in depends/mimalloc/CMakeLists.txt and depends/mimalloc/test/CMakeLists.txt (from 3.0), and in depends/relic/CMakeLists.txt (from 3.1).
• No changes to build steps beyond runner version and minimum CMake requirements; no source code or public API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title precisely describes the main change by stating that the src/dashbls dependency is being updated to a specific commit of dashpay/bls-signatures, matching the pull request’s core objective without including irrelevant information.
Description Check	✅ Passed	The description provides context by linking to the related pull request, specifying the expected subtree hash, noting that no breaking changes are expected, and including a completed checklist, all of which directly relate to the dependency update changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2350339 and b31fd98.

📒 Files selected for processing (5)

• src/dashbls/.github/workflows/build-test.yaml (1 hunks)
• src/dashbls/configure.ac (1 hunks)
• src/dashbls/depends/mimalloc/CMakeLists.txt (1 hunks)
• src/dashbls/depends/mimalloc/test/CMakeLists.txt (1 hunks)
• src/dashbls/depends/relic/CMakeLists.txt (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/{crc32c,dashbls,gsl,immer,leveldb,minisketch,secp256k1,univalue}/**

📄 CodeRabbit inference engine (CLAUDE.md)

Do not make changes under any circumstances to vendored dependencies in src/crc32c, src/dashbls, src/gsl, src/immer, src/leveldb, src/minisketch, src/secp256k1, src/univalue

Files:

• src/dashbls/depends/mimalloc/test/CMakeLists.txt
• src/dashbls/depends/mimalloc/CMakeLists.txt
• src/dashbls/depends/relic/CMakeLists.txt
• src/dashbls/configure.ac

🔇 Additional comments (5)

src/dashbls/depends/relic/CMakeLists.txt (1)

1-1: Dependency update: CMake version requirement updated.

The minimum CMake version has been updated from 3.1 to 3.14 as part of the upstream dependency update. This change aligns with the broader modernization of build requirements across the bls-signatures dependency.

As per coding guidelines, this vendored dependency file should only be updated through proper subtree merges, which this PR follows correctly.

src/dashbls/depends/mimalloc/CMakeLists.txt (1)

1-1: Dependency update: CMake version requirement updated.

The minimum CMake version has been updated from 3.0 to 3.14, consistent with the CMake modernization in other dependency files within this update.

src/dashbls/configure.ac (1)

2-2: Dependency update: Package version bumped to 1.3.6.

The libdashbls version has been updated from 1.3.5 to 1.3.6 as part of the upstream dependency update to dashpay/bls-signatures@dd683653.

src/dashbls/depends/mimalloc/test/CMakeLists.txt (1)

1-1: Dependency update: CMake version requirement updated.

The minimum CMake version has been updated from 3.0 to 3.14 in the test configuration, maintaining consistency with the main mimalloc CMakeLists.txt.

src/dashbls/.github/workflows/build-test.yaml (1)

25-25: Dependency update: CI runner updated to ubuntu-latest.

The GitHub Actions workflow has been updated to use ubuntu-latest instead of ubuntu-20.04. This change from upstream aligns with the updated CMake 3.14 requirement and ensures the CI uses a supported Ubuntu version.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[UdjinM6]

utACK b31fd98

[PastaPastaPasta]

utACK b31fd98