Skip to content

fix: compilation error with newer clang-20 #6879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

fix: compilation error with newer clang-20 #6879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,15 @@ if test "$enable_werror" = "yes"; then
fi
ERROR_CXXFLAGS=$CXXFLAG_WERROR

dnl -Wdeprecated-literal-operator cause problems with clang 20. Do not treat these warnings as errors.
Copy link

@coderabbitai coderabbitai bot Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix grammatical error in comment.

The comment uses "cause problems" but should use "causes problems" (singular verb to match the singular subject).

Apply this diff:

-  dnl -Wdeprecated-literal-operator cause problems with clang 20. Do not treat these warnings as errors.
+  dnl -Wdeprecated-literal-operator causes problems with clang 20. Do not treat these warnings as errors.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
dnl -Wdeprecated-literal-operator cause problems with clang 20. Do not treat these warnings as errors.
dnl -Wdeprecated-literal-operator causes problems with clang 20. Do not treat these warnings as errors.
🤖 Prompt for AI Agents 
In configure.ac around line 456, the comment has a grammatical error: change
"cause problems" to "causes problems" so the singular subject matches the
singular verb; update the line to read "dnl -Wdeprecated-literal-operator causes
problems with clang 20. Do not treat these warnings as errors."

dnl TODO: remove it once we update hana
AX_CHECK_COMPILE_FLAG([-Wdeprecated-literal-operator], [NOWARN_CXXFLAGS="$NOWARN_CXXFLAGS -Wno-error=deprecated-literal-operator"], [], [$CXXFLAG_WERROR], [AC_LANG_SOURCE([
#if !defined(__clang__) || defined(__INTEL_COMPILER)
#error Non-clang compiler detected, not setting flag
#endif
int main(void) { return 0; }
])])

dnl -Wattributes cause problems with some versions of GCC. Do not treat these warnings as errors.
AX_CHECK_COMPILE_FLAG([-Wattributes], [NOWARN_CXXFLAGS="$NOWARN_CXXFLAGS -Wno-error=attributes"], [], [$CXXFLAG_WERROR], [AC_LANG_SOURCE([
#if defined(__clang__) || defined(__INTEL_COMPILER) || !defined(__GNUC__)
Expand Down
Loading