Skip to content

refactor: update lock annotations for CGovernanceObject and GovernanceStore, move away from RecursiveMutexes #6849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 29, 2025
Merged

refactor: update lock annotations for CGovernanceObject and GovernanceStore, move away from RecursiveMutexes #6849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9d647e8
refactor: remove unused code
kwvg Oct 28, 2025
249d021
refactor: guard all `GovernanceStore` vars, move `cmapVoteToObject`
kwvg Oct 22, 2025
4080ee9
refactor: group together public accessor functions
kwvg Sep 15, 2025
423c1eb
refactor: add `cs` annotations for accessor functions
kwvg Oct 22, 2025
1731272
refactor: protect `GovernanceStore::cs`, add accessor to remove ext. use
kwvg Oct 28, 2025
9f5cf4a
refactor: privatize internally used functions
kwvg Sep 15, 2025
e8a1e8b
refactor: add `cs` annotations for private functions
kwvg Oct 22, 2025
7b9997c
refactor: add `cs` annotations for public functions
kwvg Sep 15, 2025
f077ca3
refactor: move from `RecursiveMutex` to `Mutex`, rename to `cs_store`
kwvg Sep 15, 2025
2378a99
trivial: tidy-up `governance/object.h`
kwvg Sep 15, 2025
2ee408f
refactor: protect some `CGovernanceObject` variables
kwvg Oct 22, 2025
009f5cb
refactor: add `cs` annotations for `CGovernanceObject`
kwvg Oct 22, 2025
14c44cb
refactor: switch `CGovernanceObject::cs` to `Mutex`
kwvg Sep 15, 2025
035dfee
fix: resolve lock order issues
kwvg Oct 28, 2025
0bc28c3
fix: resolve potential deadlock
kwvg Oct 28, 2025
828cad5
trivial: use structured bindings where possible, limit iterator scope
kwvg Oct 28, 2025
dc9787f
fix: use `std::shared_ptr` to manage `CGovernanceObject` lifetime
kwvg Oct 28, 2025
f88f15f
fix: `CGovernanceManager::Clear()` should clear all fields
kwvg Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading