Skip to content

test: fix intermittent error in wait_for_quorum_commitment #6785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025
Merged

test: fix intermittent error in wait_for_quorum_commitment #6785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3509e55
feat: a bit of extra logs when no DB_VVEC in database
knst Jul 27, 2025
848433c
fix: intermittent error in functional tests while waiting final quoru…
knst Jul 27, 2025
ab9fc70
test: apply default 0.05 delay for wait_for_quorum_commitment
knst Jul 28, 2025
928cf34
test: use '0'x96 instead 00000..0
knst Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/llmq/dkgsessionmgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,9 @@ bool CDKGSessionManager::GetVerifiedContributions(Consensus::LLMQType llmqType,
if (it == contributionsCache.end()) {
CDataStream s(SER_DISK, CLIENT_VERSION);
if (!db->ReadDataStream(std::make_tuple(DB_VVEC, llmqType, pQuorumBaseBlockIndex->GetBlockHash(), proTxHash), s)) {
LogPrint(BCLog::LLMQ, "%s -- this node does not have vvec for llmq=%d block=%s protx=%s\n",
__func__, ToUnderlying(llmqType), pQuorumBaseBlockIndex->GetBlockHash().ToString(),
proTxHash.ToString());
return false;
}
size_t vvec_size = ReadCompactSize(s);
Expand Down
4 changes: 3 additions & 1 deletion test/functional/test_framework/test_framework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2072,13 +2072,15 @@ def check_dkg_comitments():
continue
if c["quorumHash"] != quorum_hash:
continue
if c["quorumPublicKey"] == '0' * 96:
continue
c_ok = True
break
if not c_ok:
return False
return True

self.wait_until(check_dkg_comitments, timeout=timeout, sleep=1)
self.wait_until(check_dkg_comitments, timeout=timeout)

def wait_for_quorum_list(self, quorum_hash, nodes, timeout=15, llmq_type_name="llmq_test"):
def wait_func():
Expand Down
Loading