feat: bury mn_rr fork - fire up test chains by first block - 6/n #6275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
force-pushed
the
forks-speedup-p5
branch
from
b5b4c22 to
3da5423
Compare
5 tasks
|
This pull request has conflicts, please rebase. |
knst
force-pushed
the
forks-speedup-p5
branch
from
addbd87 to
6d571c1
Compare
knst
force-pushed
the
forks-speedup-p5
branch
from
6d571c1 to
8ce0d43
Compare
UdjinM6
requested changes
Sep 27, 2024
knst
force-pushed
the
forks-speedup-p5
branch
from
8ce0d43 to
0049a0f
Compare
UdjinM6
requested changes
Sep 27, 2024
knst
force-pushed
the
forks-speedup-p5
branch
from
9cebb4f to
9a9d0d5
Compare
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
Dec 10, 2024
…y first block - 7/n 906c2d7 refactor: add annotation gsl::not_null for ConstructCreditPool (Konstantin Akimov) f1905ca fix: intermittent missing of PoSe ban in feature_llmq_simplepose.py (Konstantin Akimov) cf84dff fix: bump time for all nodes during mine_quorum in feature_llmq_rotation.py test (Konstantin Akimov) efd4701 fix: intermittent error for feature_llmq_simplepose due to rotating quorums (Konstantin Akimov) 2bafadf feat: put DIP0024 activation to block 1 on RegTest (Konstantin Akimov) 632c4c4 feat: re-bury DIP0024 with new height when quorums actually appeared (Konstantin Akimov) 343c74b fix: intermittent error in feature_index_prune due to DKG influence (Konstantin Akimov) de821b9 refactor: remove command line argument -bip147height, -dip8params (Konstantin Akimov) d8ce0a7 docs: updated comment for DIP0003 activation on RegTest (Konstantin Akimov) 4dafec8 fix: add check that DIP0003 activated before retrieving CbTx for CreditPool (Konstantin Akimov) 26e9813 fix: assertion in Credit Pool validation during connecting blocks (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented This PR is 7th in the achieving ultimate goal to activate old forks from block 1. It helps to run unit and functional tests faster; it helps for platform's dev-environment to start faster. ## What was done? Prior work: #6187, #6189, #6214, #6225, #6269, #6275 This PR: - simplify DIP0024 activation and activate it from block 1 at RegTest - removes command lines arguments: -bip147height, -dip8params - fixed intermittent errors in feature_index_prune.py and feature_llmq_simplepose.py - fix assertion crash on Regtest if using strange combination of -testactivationheight and -dip3params ## How Has This Been Tested? Run unit, functional tests. ## Breaking Changes [regtest only] -dip8params, -bip147height are removed. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: utACK 906c2d7 PastaPastaPasta: utACK 906c2d7 Tree-SHA512: fab8a9bc03bb7f220c19dd952a03f8fec0b6ef1362d7308eb77c90e0ba814a241bb2bf36beccf78bb285ede1b6d85ec52fa19b3729ac9b643b420d13fbb63b47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
MN_RR is activated on mainnet: time to bury it!
What was done?
Hard-fork mn_rr is buried. Prior fixes are done here: #6270 and #6269
How Has This Been Tested?
Run unit and functional tests
Breaking Changes
N/A
Checklist: