Skip to content

Conversation

@knst
Copy link
Collaborator

@knst knst commented Sep 13, 2024

Issue being fixed or feature implemented

Too many blocks are generated in a functional tests feature_governance.py

What was done?

  1. Activate v20 faster for feature_governance.py, drop generation of useless blocks, simplify code.

  2. Added extra logging for this test by converting comments to logs.

How Has This Been Tested?

Run test/functional/feature_governance.py
Locally improvement of performance is less than 5 seconds.
tsan jobs on CI:

204/264 - feature_governance.py --legacy-wallet passed, Duration: 243 s
208/264 - feature_governance.py --descriptors passed, Duration: 270 s

old version vs new version ↓:

193/264 - feature_governance.py --legacy-wallet passed, Duration: 220 s
199/264 - feature_governance.py --descriptors passed, Duration: 240 s

Most of the time is spent in feature_governance.py on stage "let all fulfilled requests expire for re-sync to work correctly" so that's a very minor optimization.

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 21.2 milestone Sep 13, 2024
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 42dffe8

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 42dffe8

@PastaPastaPasta PastaPastaPasta merged commit 05740e8 into dashpay:develop Sep 17, 2024
@knst knst deleted the optimize-governance branch September 17, 2024 08:12
@UdjinM6 UdjinM6 modified the milestones: 21.2, 22 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants