feat: simplify and speedup feature_governance.py test by generating less blocks #6271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Too many blocks are generated in a functional tests
feature_governance.pyWhat was done?
Activate v20 faster for
feature_governance.py, drop generation of useless blocks, simplify code.Added extra logging for this test by converting comments to logs.
How Has This Been Tested?
Run
test/functional/feature_governance.pyLocally improvement of performance is less than 5 seconds.
tsanjobs on CI:↑ old version vs new version ↓:
Most of the time is spent in
feature_governance.pyon stage "let all fulfilled requests expire for re-sync to work correctly" so that's a very minor optimization.Breaking Changes
N/A
Checklist: