Skip to content

Conversation

knst
Copy link
Collaborator

@knst knst commented Sep 3, 2024

What was done?

Drop deprecated protx *_hpmn RPC entry points in favor of protx *_evo

Full list of removed composite RPC:

  • protx register_fund_hpmn
  • protx register_hpmn
  • protx register_prepare_hpmn
  • protx update_service_hpmn

How Has This Been Tested?

platform still uses it, need to replace _hpmn suffixes to _evo and remove -deprecated_hpmn from dash.conf

shumkov please be notified that mentioned RPC are going to be removed in Dash Core v22 as deprecated, this PR requires your approval

Breaking Changes

Removed RPC:

  • protx register_fund_hpmn
  • protx register_hpmn
  • protx register_prepare_hpmn
  • protx update_service_hpmn

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 22 milestone Sep 3, 2024
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add release notes

@PastaPastaPasta PastaPastaPasta marked this pull request as draft September 5, 2024 19:05
…_*_evo

Full list of removed composite RPC:
  protx register_fund_hpmn
  protx register_hpmn
  protx register_prepare_hpmn
  protx update_service_hpmn
@knst knst force-pushed the v22-deprecate-hpmn branch from cb81886 to 6f0b546 Compare September 26, 2024 07:06
@knst knst marked this pull request as ready for review September 26, 2024 07:06
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6f0b546

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6f0b546

@PastaPastaPasta PastaPastaPasta merged commit d8da094 into dashpay:develop Sep 26, 2024
27 checks passed
@thephez thephez added the RPC Some notable changes to RPC params/behaviour/descriptions label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants