fix: dash is no more pretending being a 'libdashbls' #5363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please file this pull request at https://github.com/dashpay/bls-signatures |
PastaPastaPasta
requested changes
May 10, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
I am pretty sure I agree with KW and this should be filed to the bps-signatures repo
Collaborator
|
Since dashpay/bls-signatures#76 has been merged, the subtree can be updated. |
Member
|
@knst please update the subtree instead of this patch like this |
Collaborator
Author
|
superseeded by #5466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
It resolves: #5270
What was done?
It is still workaround, but it should works more reliable that previous solution.
How Has This Been Tested?
Using project awhile - not changed to dashbls yet.
Breaking Changes
No breaking changes
Checklist: