Skip to content

fix: mark qdata request as processed only when successful #5284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ogabrielides wants to merge 3 commits into from
Closed

fix: mark qdata request as processed only when successful #5284

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff0f003
mark request as processed only when successful
ogabrielides Apr 2, 2023
8d49fb6
linter fix
ogabrielides Apr 3, 2023
8a90d8f
re-search with key
ogabrielides Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/llmq/quorums.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,13 +731,13 @@ void CQuorumManager::ProcessMessage(CNode& pfrom, const std::string& msg_type, C
CQuorumDataRequest request;
vRecv >> request;

CQuorumDataRequestKey key;
key.proRegTx = pfrom.GetVerifiedProRegTxHash();
key.flag = true;
key.quorumHash = request.GetQuorumHash();
key.llmqType = request.GetLLMQType();
{
LOCK2(cs_main, cs_data_requests);
CQuorumDataRequestKey key;
key.proRegTx = pfrom.GetVerifiedProRegTxHash();
key.flag = true;
key.quorumHash = request.GetQuorumHash();
key.llmqType = request.GetLLMQType();
auto it = mapQuorumDataRequests.find(key);
if (it == mapQuorumDataRequests.end()) {
errorHandler("Not requested");
Expand All @@ -751,7 +751,6 @@ void CQuorumManager::ProcessMessage(CNode& pfrom, const std::string& msg_type, C
errorHandler("Not like requested");
return;
}
it->second.SetProcessed();
}

if (request.GetError() != CQuorumDataRequest::Errors::NONE) {
Expand Down Expand Up @@ -816,6 +815,14 @@ void CQuorumManager::ProcessMessage(CNode& pfrom, const std::string& msg_type, C
}
}
pQuorum->WriteContributions(m_evoDb);
{
LOCK2(cs_main, cs_data_requests);
auto it = mapQuorumDataRequests.find(key);
if (it != mapQuorumDataRequests.end()) {
it->second.SetProcessed();
}
}

return;
}
}
Expand Down