refactor: remove dependency of dummyWallet in RecoverDatabaseFile on NodeContext #5178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
changed the title
PastaPastaPasta
approved these changes
Feb 4, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
Seems reasonable
2 tasks
knst
added a commit
to knst/dash
that referenced
this pull request
Feb 6, 2023
Follow up refactoring in dashpay#5178
5 tasks
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
bitcoin#15639 removes libbitcoin-server library from list of wallet linkage list.
It is not possible to remove this dependency in dash now because coinjoin hardly used libbitcoin-server in client side.
Despite that, this dependency can be removed.
What was done?
Removed NodeContext from dummyWallet by providing nullptr as a chain pointer.
How Has This Been Tested?
Validated, that linkage error "NodeContext is unknown symbol" disappeared in case if remove libbitcoin-server dependency.
Breaking Changes
No breaking changes
Checklist: