Skip to content

[v18.2.x] docs: add release notes for v18.2.0 #5129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UdjinM6 merged 3 commits into from
Jan 2, 2023
Merged

[v18.2.x] docs: add release notes for v18.2.0 #5129

UdjinM6 merged 3 commits into from
Jan 2, 2023

Conversation

@PastaPastaPasta
Copy link
Member

@PastaPastaPasta PastaPastaPasta commented Dec 30, 2022 •
edited
Loading

Issue being fixed or feature implemented

adds release notes

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

UdjinM6
UdjinM6 requested changes Dec 30, 2022
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should go into v18.2.x branch first and should be brought into develop via "merge master into develop" PR after v18.2 release.

thephez
thephez reviewed Dec 31, 2022
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions

thephez
thephez previously approved these changes Jan 1, 2023
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UdjinM6 UdjinM6 added this to the 18.2 milestone Jan 1, 2023
UdjinM6
UdjinM6 previously approved these changes Jan 1, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to do it this way #5129 (review). But utACK in case you want to do it like for #5128.

@UdjinM6 UdjinM6 mentioned this pull request Jan 1, 2023
Merged
5 tasks
PastaPastaPasta and others added 3 commits January 1, 2023 17:52
@PastaPastaPasta PastaPastaPasta dismissed stale reviews from UdjinM6 and thephez via c7513c5 January 1, 2023 23:52
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

This pull request has conflicts, please rebase.

@PastaPastaPasta PastaPastaPasta changed the title docs: add release notes for v18.2.x [v18.2.x] docs: add release notes for v18.2.x Jan 1, 2023
@PastaPastaPasta PastaPastaPasta changed the base branch from develop to v18.2.x January 1, 2023 23:53
@PastaPastaPasta PastaPastaPasta changed the title [v18.2.x] docs: add release notes for v18.2.x [v18.2.x] chore: final changes for v18.2.0 Jan 1, 2023
@PastaPastaPasta PastaPastaPasta changed the title [v18.2.x] chore: final changes for v18.2.0 [v18.2.x] docs: add release notes for v18.2.x Jan 2, 2023
@UdjinM6 UdjinM6 changed the title [v18.2.x] docs: add release notes for v18.2.x [v18.2.x] docs: add release notes for v18.2.0 Jan 2, 2023
UdjinM6
UdjinM6 approved these changes Jan 2, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit fe2d7d3 into dashpay:v18.2.x Jan 2, 2023
@PastaPastaPasta PastaPastaPasta deleted the v18.2.x-release-notes branch January 2, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@thephez thephez thephez left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.2

Development

Successfully merging this pull request may close these issues.

3 participants

@PastaPastaPasta @UdjinM6 @thephez