Bitcoin backport related to CWallet refactoring: bitcoin#17304, partial #10235#4993

Merged

PastaPastaPasta merged 21 commits intodashpay:developfrom

knst:bc-bp-cwallet-4

Sep 20, 2022

Commits on Aug 29, 2022

MOVEONLY: Reorder LegacyScriptPubKeyMan methods

achow101
authored and
knst
committed
Refactor: Declare LegacyScriptPubKeyMan methods as virtual

achow101
authored and
knst
committed
Refactor: Add new ScriptPubKeyMan virtual methods

achow101
authored and
knst
committed
Refactor: Move SetAddressBook call out of LegacyScriptPubKeyMan::GetNewDestination

achow101
authored and
knst
committed
Refactor: Move SetWalletFlag out of LegacyScriptPubKeyMan::UpgradeKeyMetadata

achow101
authored and
knst
committed
Remove SetWalletFlag from WalletStorage

achow101
authored and
knst
committed
Refactor: Remove UnsetWalletFlag call from LegacyScriptPubKeyMan::SetHDSeed

achow101
authored and
knst
committed
refactor: Replace UnsetWalletFlagWithDB with UnsetBlankWalletFlag in ScriptPubKeyMan

achow101
authored and
knst
committed
Refactor: Move SetAddressBookWithDB call out of LegacyScriptPubKeyMan::ImportScriptPubKeys

achow101
authored and
knst
committed
Refactor: Move LoadKey LegacyScriptPubKeyMan method definition

achow101
authored and
knst
committed
Refactor: Move GetMetadata code out of getaddressinfo

achow101
authored and
knst
committed
Refactor: Move MarkUnusedAddresses code out of CWallet::AddToWalletIfInvolvingMe

achow101
authored and
knst
committed
Refactor: Move HavePrivateKeys code out of CWallet::CreateWalletFromFile

achow101
authored and
knst
committed
Refactor: Move RewriteDB code out of CWallet

achow101
authored and
knst
committed
Refactor: Move GetKeypoolSize code out of CWallet

achow101
authored and
knst
committed
Refactor: Move nTimeFirstKey accesses out of CWallet

achow101
authored and
knst
committed
Re-order methods of scriptpubkeyman for easier backporting changes in future
knst
committed

Commits on Aug 30, 2022

Fixup for missing cs_wallet lock:
knst
committed

Commits on Sep 13, 2022

Fix 2 locks

UdjinM6
authored and
knst
committed
more of "refactor: Replace UnsetWalletFlagWithDB with UnsetBlankWalletFlag in ScriptPubKeyMan"

UdjinM6
authored and
knst
committed
Refactoring GetOldestKeyInPool -> GetOldestKeyTimeInPool, partial bitcoin#10235
knst
committed