refactor: implement irange::range and use it #4788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvg
reviewed
Apr 20, 2022
| @@ -0,0 +1,90 @@ | |||
| // Copyright (c) 2021 The Dash Core developers | |||
There was a problem hiding this comment.
along with referring original implementation as a source, adding their copyright is probably for the best, also mention the commit of cpp_range from which this was derived from
There was a problem hiding this comment.
They didn't have a copyright on the file, just a MIT license in the folder
|
see latest |
PastaPastaPasta
commented
Apr 20, 2022
PastaPastaPasta
commented
Apr 20, 2022
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
force-pushed
the
refac-irange
branch
from
ca2fb53 to
1645242
Compare
UdjinM6
requested changes
Apr 20, 2022
| workerPool.push([pQuorum, t, this](int threadId) { | ||
| for (size_t i = 0; i < pQuorum->members.size() && !quorumThreadInterrupt; i++) { | ||
| for (const auto i : irange::range(pQuorum->members.size())) { | ||
| if (!quorumThreadInterrupt) { |
There was a problem hiding this comment.
Suggested change
| if (!quorumThreadInterrupt) { | |
| if (quorumThreadInterrupt) { |
|
pls see 49f76c6 |
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
force-pushed
the
refac-irange
branch
from
88c31b0 to
c5572b0
Compare
PastaPastaPasta
force-pushed
the
refac-irange
branch
from
68a4ac2 to
50f31b2
Compare
5 tasks
PastaPastaPasta
pushed a commit
that referenced
this pull request
Nov 27, 2023
#5732) ## Issue being fixed or feature implemented #4788 (comment) noticed while working on #5731 ## What was done? ## How Has This Been Tested? run a node, check logs - there is a meaningful time span between `start` and `done` now and not just zeros all the time. ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.