Merge #16291: gui: Stop translating PACKAGE_NAME #4723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa64b94 util: No translation of `Bitcoin Core` in the copyright (MarcoFalke) fab8520 qt: Run «make translate» in ./src/ (MarcoFalke) fabe87d scripted-diff: Avoid passing PACKAGE_NAME for translation (MarcoFalke) fa5e9f1 build: Stop translating PACKAGE_NAME (MarcoFalke) Pull request description: Generally the package name is not translated, but the package description is. E.g. `GIMP` or `Firefox` are always called that way regardless of the system language. However, "`Firefox` webbrowser" or "`GIMP` image manipulation program" are translated. ACKs for top commit: hebasto: ACK fa64b94, I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged. Tree-SHA512: 626f811531182d0ba0ef1044930d32726773349bcb49b10261288a86ee6b80a183db30a87d817d5b0d501fad058ac22d6272311716b4f5a154f17c6f391a5a1a
UdjinM6
requested changes
Mar 13, 2022
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
pls see b2276df119ffe697940419110a96e1c4cd8e86c5
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 11, 2023
* Merge bitcoin#16291: gui: Stop translating PACKAGE_NAME fa64b94 util: No translation of `Bitcoin Core` in the copyright (MarcoFalke) fab8520 qt: Run «make translate» in ./src/ (MarcoFalke) fabe87d scripted-diff: Avoid passing PACKAGE_NAME for translation (MarcoFalke) fa5e9f1 build: Stop translating PACKAGE_NAME (MarcoFalke) Pull request description: Generally the package name is not translated, but the package description is. E.g. `GIMP` or `Firefox` are always called that way regardless of the system language. However, "`Firefox` webbrowser" or "`GIMP` image manipulation program" are translated. ACKs for top commit: hebasto: ACK fa64b94, I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged. Tree-SHA512: 626f811531182d0ba0ef1044930d32726773349bcb49b10261288a86ee6b80a183db30a87d817d5b0d501fad058ac22d6272311716b4f5a154f17c6f391a5a1a * more Co-authored-by: MarcoFalke <falke.marco@gmail.com> Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
* Merge bitcoin#16291: gui: Stop translating PACKAGE_NAME fa64b94 util: No translation of `Bitcoin Core` in the copyright (MarcoFalke) fab8520 qt: Run «make translate» in ./src/ (MarcoFalke) fabe87d scripted-diff: Avoid passing PACKAGE_NAME for translation (MarcoFalke) fa5e9f1 build: Stop translating PACKAGE_NAME (MarcoFalke) Pull request description: Generally the package name is not translated, but the package description is. E.g. `GIMP` or `Firefox` are always called that way regardless of the system language. However, "`Firefox` webbrowser" or "`GIMP` image manipulation program" are translated. ACKs for top commit: hebasto: ACK fa64b94, I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged. Tree-SHA512: 626f811531182d0ba0ef1044930d32726773349bcb49b10261288a86ee6b80a183db30a87d817d5b0d501fad058ac22d6272311716b4f5a154f17c6f391a5a1a * more Co-authored-by: MarcoFalke <falke.marco@gmail.com> Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fa64b94 util: No translation of
Bitcoin Corein the copyright (MarcoFalke)fab8520 qt: Run «make translate» in ./src/ (MarcoFalke)
fabe87d scripted-diff: Avoid passing PACKAGE_NAME for translation (MarcoFalke)
fa5e9f1 build: Stop translating PACKAGE_NAME (MarcoFalke)
Pull request description:
Generally the package name is not translated, but the package description is.
E.g.
GIMPorFirefoxare always called that way regardless of the system language. However, "Firefoxwebbrowser" or "GIMPimage manipulation program" are translated.ACKs for top commit:
hebasto:
ACK fa64b94, I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged.
Tree-SHA512: 626f811531182d0ba0ef1044930d32726773349bcb49b10261288a86ee6b80a183db30a87d817d5b0d501fad058ac22d6272311716b4f5a154f17c6f391a5a1a