Merge #16129 : refactor unused includes

src/addrman.cpp

@@ -7,7 +7,6 @@
 
 #include <hash.h>
 #include <logging.h>
-#include <streams.h>
 #include <serialize.h>
 
 int CAddrInfo::GetTriedBucket(const uint256& nKey, const std::vector<bool> &asmap) const

src/arith_uint256.cpp

@@ -6,7 +6,6 @@
 #include <arith_uint256.h>
 
 #include <uint256.h>
-#include <util/strencodings.h>
 #include <crypto/common.h>
 
 

src/bench/rpc_mempool.cpp

@@ -3,7 +3,6 @@
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
 #include <bench/bench.h>
-#include <policy/policy.h>
 #include <rpc/blockchain.h>
 #include <txmempool.h>
 

src/consensus/merkle.cpp

@@ -4,7 +4,6 @@
 
 #include <consensus/merkle.h>
 #include <hash.h>
-#include <util/strencodings.h>
 
 /*     WARNING! If you're reading this because you're learning about crypto
        and/or designing a new system that will use merkle trees, keep in mind

src/core_write.cpp

@@ -12,7 +12,6 @@
 #include <serialize.h>
 #include <streams.h>
 #include <univalue.h>
-#include <util/moneystr.h>
 #include <util/strencodings.h>
 
 #include <spentindex.h>

src/crypto/aes.cpp

@@ -3,7 +3,6 @@
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
 #include <crypto/aes.h>
-#include <crypto/common.h>
 
 #include <string.h>
 

src/crypto/sha256_avx2.cpp

@@ -3,7 +3,6 @@
 #include <stdint.h>
 #include <immintrin.h>
 
-#include <crypto/sha256.h>
 #include <crypto/common.h>
 
 namespace sha256d64_avx2 {

src/crypto/sha256_sse41.cpp

@@ -3,7 +3,6 @@
 #include <stdint.h>
 #include <immintrin.h>
 
-#include <crypto/sha256.h>
 #include <crypto/common.h>
 
 namespace sha256d64_sse41 {

src/dash-wallet.cpp

@@ -8,7 +8,6 @@
 
 #include <chainparams.h>
 #include <chainparamsbase.h>
-#include <consensus/consensus.h>
 #include <logging.h>
 #include <util/system.h>
 #include <util/strencodings.h>

src/dashd.cpp

@@ -13,15 +13,11 @@
 #include <compat.h>
 #include <init.h>
 #include <interfaces/chain.h>
-#include <rpc/server.h>
 #include <noui.h>
 #include <shutdown.h>
 #include <util/system.h>
-#include <httpserver.h>
-#include <httprpc.h>
 #include <util/strencodings.h>
 #include <util/threadnames.h>
-#include <walletinitinterface.h>
 #include <stacktraces.h>
 
 #include <stdio.h>

src/httprpc.cpp

@@ -8,7 +8,6 @@
 #include <httpserver.h>
 #include <rpc/protocol.h>
 #include <rpc/server.h>
-#include <random.h>
 #include <util/system.h>
 #include <util/strencodings.h>
 #include <ui_interface.h>

src/init.cpp

@@ -70,7 +70,6 @@
 #include <messagesigner.h>
 #include <netfulfilledman.h>
 #include <spork.h>
-#include <warnings.h>
 #include <walletinitinterface.h>
 
 #include <evo/deterministicmns.h>

src/interfaces/node.cpp

@@ -26,7 +26,6 @@
 #include <policy/settings.h>
 #include <primitives/block.h>
 #include <rpc/server.h>
-#include <scheduler.h>
 #include <shutdown.h>
 #include <sync.h>
 #include <txmempool.h>

src/interfaces/wallet.cpp

@@ -9,11 +9,8 @@
 #include <consensus/validation.h>
 #include <interfaces/chain.h>
 #include <interfaces/handler.h>
-#include <net.h>
 #include <policy/fees.h>
 #include <primitives/transaction.h>
-#include <rpc/server.h>
-#include <scheduler.h>
 #include <script/ismine.h>
 #include <script/standard.h>
 #include <support/allocators/secure.h>

src/key.cpp

@@ -5,7 +5,6 @@
 
 #include <key.h>
 
-#include <arith_uint256.h>
 #include <crypto/common.h>
 #include <crypto/hmac_sha512.h>
 #include <random.h>

src/merkleblock.cpp

@@ -7,7 +7,6 @@
 
 #include <hash.h>
 #include <consensus/consensus.h>
-#include <util/strencodings.h>
 
 
 std::vector<unsigned char> BitsToBytes(const std::vector<bool>& bits)

src/miner.cpp

@@ -21,7 +21,6 @@
 #include <util/system.h>
 #include <util/moneystr.h>
 #include <util/validation.h>
-#include <validationinterface.h>
 
 #include <evo/specialtx.h>
 #include <evo/cbtx.h>

src/net_processing.cpp

@@ -28,7 +28,6 @@
 #include <index/txindex.h>
 #include <txmempool.h>
 #include <util/system.h>
-#include <util/moneystr.h>
 #include <util/strencodings.h>
 #include <util/validation.h>
 

src/netbase.cpp

@@ -6,7 +6,6 @@
 #include <netbase.h>
 
 #include <sync.h>
-#include <uint256.h>
 #include <tinyformat.h>
 #include <util/system.h>
 #include <util/strencodings.h>

src/policy/policy.cpp

@@ -9,7 +9,6 @@
 
 #include <coins.h>
 #include <policy/settings.h>
-#include <util/strencodings.h>
 
 
 CAmount GetDustThreshold(const CTxOut& txout, const CFeeRate& dustRelayFeeIn)

src/primitives/block.cpp

@@ -8,7 +8,6 @@
 #include <hash.h>
 #include <streams.h>
 #include <tinyformat.h>
-#include <util/strencodings.h>
 
 uint256 CBlockHeader::GetHash() const
 {

src/qt/addressbookpage.cpp

@@ -11,7 +11,6 @@
 #include <qt/forms/ui_addressbookpage.h>
 
 #include <qt/addresstablemodel.h>
-#include <qt/bitcoingui.h>
 #include <qt/csvmodelwriter.h>
 #include <qt/editaddressdialog.h>
 #include <qt/guiutil.h>

src/qt/addresstablemodel.cpp

@@ -8,7 +8,6 @@
 #include <qt/guiutil.h>
 #include <qt/walletmodel.h>
 
-#include <interfaces/node.h>
 #include <key_io.h>
 
 #include <algorithm>

src/qt/bantablemodel.cpp

@@ -5,8 +5,6 @@
 #include <qt/bantablemodel.h>
 
 #include <qt/clientmodel.h>
-#include <qt/guiconstants.h>
-#include <qt/guiutil.h>
 
 #include <interfaces/node.h>
 

src/qt/bitcoinunits.cpp

@@ -5,7 +5,6 @@
 
 #include <qt/bitcoinunits.h>
 #include <chainparams.h>
-#include <primitives/transaction.h>
 
 #include <QSettings>
 #include <QStringList>

src/qt/clientmodel.cpp

@@ -12,19 +12,13 @@
 
 #include <evo/deterministicmns.h>
 
-#include <chain.h>
-#include <chainparams.h>
 #include <clientversion.h>
 #include <governance/object.h>
 #include <interfaces/handler.h>
 #include <interfaces/node.h>
 #include <net.h>
 #include <netbase.h>
-#include <txmempool.h>
-#include <ui_interface.h>
 #include <util/system.h>
-#include <validation.h>
-#include <warnings.h>
 
 #include <stdint.h>
 

src/qt/coincontroldialog.cpp

@@ -11,19 +11,15 @@
 #include <qt/forms/ui_coincontroldialog.h>
 
 #include <qt/addresstablemodel.h>
-#include <base58.h>
 #include <qt/bitcoinunits.h>
 #include <qt/guiutil.h>
 #include <qt/optionsmodel.h>
-#include <txmempool.h>
 #include <qt/walletmodel.h>
 
 #include <wallet/coincontrol.h>
 #include <interfaces/node.h>
 #include <key_io.h>
 #include <policy/policy.h>
-#include <validation.h> // For mempool
-#include <wallet/fees.h>
 #include <wallet/wallet.h>
 
 #include <QApplication>

src/qt/dash.cpp

@@ -31,14 +31,10 @@
 #include <interfaces/handler.h>
 #include <interfaces/node.h>
 #include <noui.h>
-#include <rpc/server.h>
 #include <stacktraces.h>
 #include <ui_interface.h>
 #include <uint256.h>
 #include <util/system.h>
-#include <warnings.h>
-
-#include <walletinitinterface.h>
 
 #include <memory>
 #include <stdint.h>

src/qt/receivecoinsdialog.cpp

@@ -5,9 +5,7 @@
 #include <qt/receivecoinsdialog.h>
 #include <qt/forms/ui_receivecoinsdialog.h>
 
-#include <qt/addressbookpage.h>
 #include <qt/addresstablemodel.h>
-#include <qt/bitcoinunits.h>
 #include <qt/optionsmodel.h>
 #include <qt/receiverequestdialog.h>
 #include <qt/recentrequeststablemodel.h>

src/qt/test/addressbooktests.cpp

@@ -4,8 +4,6 @@
 
 #include <interfaces/chain.h>
 #include <interfaces/node.h>
-#include <qt/addressbookpage.h>
-#include <qt/addresstablemodel.h>
 #include <qt/editaddressdialog.h>
 #include <qt/optionsmodel.h>
 #include <qt/qvalidatedlineedit.h>

src/qt/test/apptests.cpp

@@ -5,7 +5,6 @@
 #include <qt/test/apptests.h>
 
 #include <chainparams.h>
-#include <init.h>
 #include <key.h>
 #include <qt/dash.h>
 #include <qt/bitcoingui.h>
@@ -19,9 +18,6 @@
 #if defined(HAVE_CONFIG_H)
 #include <config/dash-config.h>
 #endif
-#ifdef ENABLE_WALLET
-#include <wallet/db.h>
-#endif
 
 #include <QAction>
 #include <QEventLoop>

src/qt/test/rpcnestedtests.cpp

@@ -4,11 +4,7 @@
 
 #include <qt/test/rpcnestedtests.h>
 
-#include <chainparams.h>
-#include <consensus/validation.h>
 #include <interfaces/node.h>
-#include <validation.h>
-#include <rpc/register.h>
 #include <rpc/server.h>
 #include <qt/rpcconsole.h>
 #include <test/setup_common.h>

src/qt/test/wallettests.cpp

@@ -2,10 +2,8 @@
 #include <qt/test/util.h>
 
 #include <coinjoin/client.h>
-#include <init.h>
 #include <interfaces/chain.h>
 #include <interfaces/node.h>
-#include <base58.h>
 #include <qt/bitcoinamountfield.h>
 #include <qt/clientmodel.h>
 #include <qt/optionsmodel.h>

src/qt/transactionrecord.cpp

@@ -6,11 +6,8 @@
 #include <qt/transactionrecord.h>
 
 #include <chain.h>
-#include <consensus/consensus.h>
 #include <interfaces/wallet.h>
 #include <interfaces/node.h>
-#include <timedata.h>
-#include <validation.h>
 
 #include <stdint.h>
 

src/qt/transactiontablemodel.cpp

@@ -12,11 +12,8 @@
 
 #include <core_io.h>
 #include <interfaces/handler.h>
-#include <interfaces/node.h>
-#include <sync.h>
 #include <uint256.h>
 #include <util/system.h>
-#include <validation.h>
 
 #include <algorithm>
 

src/qt/utilitydialog.cpp

@@ -12,17 +12,13 @@
 #include <qt/forms/ui_helpmessagedialog.h>
 
 #include <qt/bitcoingui.h>
-#include <qt/clientmodel.h>
-#include <qt/guiconstants.h>
 #include <qt/guiutil.h>
-#include <qt/intro.h>
 #ifdef ENABLE_BIP70
 #include <qt/paymentrequestplus.h>
 #endif
 
 #include <clientversion.h>
 #include <init.h>
-#include <interfaces/node.h>
 #include <util/system.h>
 #include <util/strencodings.h>
 

src/qt/walletmodeltransaction.cpp

@@ -8,7 +8,6 @@
 
 #include <qt/walletmodeltransaction.h>
 
-#include <interfaces/node.h>
 #include <key_io.h>
 
 WalletModelTransaction::WalletModelTransaction(const QList<SendCoinsRecipient> &_recipients) :

src/rpc/misc.cpp

@@ -10,7 +10,6 @@
 #include <httpserver.h>
 #include <key_io.h>
 #include <net.h>
-#include <netbase.h>
 #include <rpc/blockchain.h>
 #include <rpc/server.h>
 #include <rpc/util.h>