cj: Fix deadlock in SignFinalTransaction #4474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PastaPastaPasta
previously approved these changes
Oct 1, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
``` POTENTIAL DEADLOCK DETECTED Previous lock order was: cs_deqsessions coinjoin/coinjoin-client.cpp:141 (in thread ) ::mempool.cs coinjoin/coinjoin-client.cpp:561 (in thread ) (1) cs_coinjoin coinjoin/coinjoin-client.cpp:561 (in thread ) (2) cs_wallet wallet/wallet.cpp:315 (in thread ) Current lock order is: cs_deqsessions coinjoin/coinjoin-client.cpp:980 (in thread ) cs_main coinjoin/coinjoin-client.cpp:788 (in thread ) mempool.cs coinjoin/coinjoin-client.cpp:788 (in thread ) (2) mixingWallet.cs_wallet coinjoin/coinjoin-client.cpp:789 (in thread ) (1) cs_coinjoin ./coinjoin/coinjoin.h:369 (in thread ) ``` Introduced in 4463
|
This pull request has conflicts, please rebase. |
|
This pull request has conflicts, please rebase. |
Author
|
rebased after #4475 |
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
``` POTENTIAL DEADLOCK DETECTED Previous lock order was: cs_deqsessions coinjoin/coinjoin-client.cpp:141 (in thread ) ::mempool.cs coinjoin/coinjoin-client.cpp:561 (in thread ) (1) cs_coinjoin coinjoin/coinjoin-client.cpp:561 (in thread ) (2) cs_wallet wallet/wallet.cpp:315 (in thread ) Current lock order is: cs_deqsessions coinjoin/coinjoin-client.cpp:980 (in thread ) cs_main coinjoin/coinjoin-client.cpp:788 (in thread ) mempool.cs coinjoin/coinjoin-client.cpp:788 (in thread ) (2) mixingWallet.cs_wallet coinjoin/coinjoin-client.cpp:789 (in thread ) (1) cs_coinjoin ./coinjoin/coinjoin.h:369 (in thread ) ``` Introduced in 4463
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 7, 2023
``` POTENTIAL DEADLOCK DETECTED Previous lock order was: cs_deqsessions coinjoin/coinjoin-client.cpp:141 (in thread ) ::mempool.cs coinjoin/coinjoin-client.cpp:561 (in thread ) (1) cs_coinjoin coinjoin/coinjoin-client.cpp:561 (in thread ) (2) cs_wallet wallet/wallet.cpp:315 (in thread ) Current lock order is: cs_deqsessions coinjoin/coinjoin-client.cpp:980 (in thread ) cs_main coinjoin/coinjoin-client.cpp:788 (in thread ) mempool.cs coinjoin/coinjoin-client.cpp:788 (in thread ) (2) mixingWallet.cs_wallet coinjoin/coinjoin-client.cpp:789 (in thread ) (1) cs_coinjoin ./coinjoin/coinjoin.h:369 (in thread ) ``` Introduced in 4463
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
``` POTENTIAL DEADLOCK DETECTED Previous lock order was: cs_deqsessions coinjoin/coinjoin-client.cpp:141 (in thread ) ::mempool.cs coinjoin/coinjoin-client.cpp:561 (in thread ) (1) cs_coinjoin coinjoin/coinjoin-client.cpp:561 (in thread ) (2) cs_wallet wallet/wallet.cpp:315 (in thread ) Current lock order is: cs_deqsessions coinjoin/coinjoin-client.cpp:980 (in thread ) cs_main coinjoin/coinjoin-client.cpp:788 (in thread ) mempool.cs coinjoin/coinjoin-client.cpp:788 (in thread ) (2) mixingWallet.cs_wallet coinjoin/coinjoin-client.cpp:789 (in thread ) (1) cs_coinjoin ./coinjoin/coinjoin.h:369 (in thread ) ``` Introduced in 4463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #4463